Name the softfp world vita_softfp - #47
Merged
Merged
Conversation
makepkg builds shell variable names out of CARCH, so a world with a hyphen in its name aborts every build in it. See vitasdk/buildscripts, which stamps the name into the core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows vitasdk/buildscripts#184, which has the diagnosis: makepkg turns
CARCHinto shell variable names (depends_$CARCHand six more), so a hyphen in a world's name aborts every build in that world — and silently injects the literal stringsoftfp[@]into all seven arrays on the way there.This is the same rename on this side: the two
WORLDStuples and the tests. Tag and channel names are built separately and keep their hyphens.🤖 Generated with Claude Code