Skip to content

Commit 246cbfe

Browse files
committed
Say which half of the version guard is actually wired
The patch document ended on "nothing passes --previous-version in production yet", and autobuilds has passed it since its #39 -- but only where a version is derived. On a tree that declares one the step exits before the call, because the only previous version stored is the world's last candidate, and every nightly sorts below every stable, so comparing across them says nothing. Which leaves the number a person types into VERSION checked by nobody, in a document whose whole point is the release where a person types it. Said plainly now, along with what it would have to be compared against.
1 parent 0926bc7 commit 246cbfe

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

docs/patch-release.md

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,5 +130,12 @@ the version is known, and closed at the other end by the pair check in step 6.
130130
**And one hole found while looking:** `--previous-version` skipped a committed
131131
`VERSION` outright, so the guard that stops a version going backwards covered
132132
only the derived path — the one where it cannot happen by accident — and not
133-
the one where a person types the number. Closed in `287d8a8f4`. Nothing passes
134-
`--previous-version` in production yet.
133+
the one where a person types the number. Closed in `287d8a8f4`.
134+
135+
`vitasdk/autobuilds` passes it since its #39, but only for a derived version:
136+
the step bails out on a tree that declares one, because the previous version
137+
it has is the world's last candidate, and every nightly sorts below every
138+
stable, so the comparison would say nothing. **The number typed into `VERSION`
139+
is still checked by nobody.** What it would have to be compared against is the
140+
series' own current version — readable from the lock inside the core that
141+
`channels.json` points at — and nothing reads that yet.

0 commit comments

Comments
 (0)