Skip to content

Commit 68d0492

Browse files
committed
Fix vita-makepkg dropping the world's CARCH in bin/makepkg.conf
Regressed by an earlier git checkout -- in this same session that reverted this file to HEAD and got only partially undone: vita-makepkg went back to a plain copy of makepkg.conf.sample, which always says CARCH="vita", instead of running it through WriteMakepkgConf.cmake. Caught by CI, not locally: validate-core-package.sh's own world-coherence check failed a real vita-softfp build with "version_info.txt says vita-softfp, bin/makepkg.conf CARCH says vita" on every host.
1 parent 112cbab commit 68d0492

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

cmake/recipes/BuildHostTools.cmake

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,10 @@ ExternalProject_Add(vita-makepkg
7979
INSTALL_COMMAND ${CMAKE_COMMAND} -E make_directory ${CMAKE_INSTALL_PREFIX}/bin/
8080
COMMAND ${CMAKE_COMMAND} -E copy_directory <SOURCE_DIR>/libmakepkg ${CMAKE_INSTALL_PREFIX}/bin/libmakepkg
8181
COMMAND ${CMAKE_COMMAND} -E copy <SOURCE_DIR>/vita-makepkg ${CMAKE_INSTALL_PREFIX}/bin/
82-
COMMAND ${CMAKE_COMMAND} -E copy <SOURCE_DIR>/makepkg.conf.sample ${CMAKE_INSTALL_PREFIX}/bin/makepkg.conf
82+
COMMAND ${CMAKE_COMMAND}
83+
-DINPUT=<SOURCE_DIR>/makepkg.conf.sample
84+
-DOUTPUT=${CMAKE_INSTALL_PREFIX}/bin/makepkg.conf
85+
-DWORLD_ARCH=${world_arch}
86+
-P ${PROJECT_SOURCE_DIR}/cmake/WriteMakepkgConf.cmake
8387
${UPDATE_DISCONNECTED_SUPPORT}
8488
)

cmake/recipes/BuildSdkComponents.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,4 +106,3 @@ ExternalProject_Add(samples
106106
COMMAND ${GIT_EXECUTABLE} -C <SOURCE_DIR> rev-parse HEAD > ${CMAKE_BINARY_DIR}/samples-version.txt
107107
${UPDATE_DISCONNECTED_SUPPORT}
108108
)
109-

0 commit comments

Comments
 (0)