Take the vita-makepkg that finds the package client - #174
Merged
Conversation
vita-makepkg bbd1b18 stops defaulting PACMAN to $VITASDK/bin/pacman, which is not where the client is: vdpm installs it at libexec/vdpm/pacman, deliberately off PATH so a Linux distribution's own pacman stays reachable as plain "pacman". Nothing here hit it, because the core build hands vita-makepkg a PACMAN of its own -- but a recipe built by hand against an installed SDK did not. Its sibling commit fixes a test that had been failing on that repository since 32f863c, silently: a bare grep under set -e, exit 1 having printed nothing. The assertions still spelled out the --noscriptlet that 32f863c stopped passing on queries. The pin stays untracked in cmake/pin-tracking.json: what changes here is packaging behaviour the core package depends on, so it moves when somebody has read it, which is now.
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
VITA_MAKEPKG_TAGfrom32f863ctobbd1b18— vitasdk/vita-makepkg#12, two commits.The fix.
PACMANdefaulted to$VITASDK/bin/pacman. The client is not there and never has been:vdpminstalls it atlibexec/vdpm/pacman, deliberately offPATHso a Linux distribution's own pacman stays reachable as plainpacman— the reason is written next to the#defineinvdpm/src/vdpm.c. WithoutPACMANset,PACMAN_PATHresolved to nothing and the first thing needing the client died withCannot find the VitaSDK package client: …/bin/pacman, exit 126.Nothing in this repository hit it, because the core build passes a
PACMANof its own. What hit it is anybody building a recipe by hand against an installed SDK.And a test that had gone quiet.
32f863cstoppedrun_pacmanpassing--noscriptleton queries, because pacman 7.1 rejects it there. Three assertions over the recorded arguments still spelled out the old invocation, sotests/test-dependency-resolution.shhad been failing on that repository ever since — silently, at a baregrepunderset -e, printing nothing at all. The first commit of #12 corrects them and adds the check from the other side, so the rule is watched rather than merely established.Why this is a hand-move
vita-makepkgsits in theuntrackedhalf ofcmake/pin-tracking.json, with its reason attached:Which is exactly what changed here, so it moves when somebody has read it. The bot is not the right instrument for this pin, and I have not moved it into
tracked.The matching pin in
vitasdk/vitasdk-autobuild(VITA_MAKEPKG_REFinvitasdk_autobuild/config.py, for the supervisor, which runs on a bare runner) moves in its own pull request.Checked
describereads the pin at the committed revision, and it picks this up:All 9 CI tests and 6 protocol tests pass locally. The build itself is what CI is for: this changes a component that goes into every core package, so every packaged host rebuilds it.
AI tools were used in preparing this PR (Claude Opus 5, Anthropic).