Build the softfp shims with the compiler that exists - #180
Merged
Conversation
The shim command depended on gcc-base. The staged pipeline builds no such target -- it goes binutils and vita-headers, then newlib, then gcc-final -- so asking for the shims failed with No rule to make target 'gcc-base', needed by 'softfp-shim.stamp' and took the sysroot with it. The dependency has been dangling since this was rebased onto the staged pipeline; nothing reached the target until the export started waiting for it, so nothing said so. It now waits for gcc_final_barrier, which is a variable and not yet set where the command used to live, so the recipe moves to a file of its own included after BuildGccFinal. Stage 2 does not include it: it imports the archives already spliced and builds no components. The test checks the recipe names no compiler that is not built, that it waits for the one that is, and that it is included after it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shim command depended on
gcc-base. The staged pipeline builds no such target — it goes binutils and vita-headers, then newlib, thengcc-final— so asking for the shims failed withand took the sysroot with it. The dependency has been dangling since this was rebased onto the staged pipeline. Nothing reached the target until #179 made the export wait for it, so nothing said so.
It now waits for
gcc_final_barrier. That is a variable, not yet set where the command used to live, so the recipe moves tocmake/recipes/SoftfpShims.cmake, included afterBuildGccFinal. Stage 2 does not include it: it imports the archives already spliced and builds no components.The test checks the recipe names no compiler that is not built, that it waits for the one that is, and that it is included after it.
🤖 Generated with Claude Code