fix: fetch star totals via stargazerCount, not the stargazers connection (#313)

Between July 22 and 23 GitHub's GraphQL API stopped serving the
`stargazers` connection to integration tokens (the built-in Actions
GITHUB_TOKEN), answering "Resource not accessible by integration" with the
rest of the document intact. assertNoGraphQLErrors treats any errors array
as fatal, so exactly the two cards whose queries touch that field —
ProfileDetailsCard and StatsCard — failed outright for every Action user
on the default token setup, while PAT-backed runs (and the hosted service)
kept working. Nothing changed on our side: the same release build was
clean on the 22nd and failing on the 23rd (#311).

The queries only ever read `stargazers { totalCount }`. `stargazerCount`
returns the same number, is cheaper, and is verified to work with
integration tokens — swap it in across the profile-details documents
(combined, split core, star pagination) and the organization query.

This also unblocks the planned move of the hosted service onto a GitHub
App installation token, which would have hit the same restriction.

Fixes #311.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Author: vn7n24fzkq

src/github-api/organization-details.ts

@@ -61,9 +61,7 @@ const fetcher = (token: string, variables: any) => {
                     nodes {
                         createdAt
                         forkCount
-                        stargazers {
-                            totalCount
-                        }
+                        stargazerCount
                         issues(states: OPEN) {
                             totalCount
                         }
@@ -144,7 +142,7 @@ export async function getOrganizationDetails(login: string, token: string): Prom
     organizationDetails.totalPublicRepos = org.totalPublicRepos;
 
     for (const node of nodes) {
-        organizationDetails.totalStars += node.stargazers.totalCount;
+        organizationDetails.totalStars += node.stargazerCount;
         organizationDetails.totalForks += node.forkCount;
         organizationDetails.totalOpenIssues += node.issues.totalCount;
         organizationDetails.repoCreatedAt.push(new Date(node.createdAt));

src/github-api/profile-details.ts

@@ -57,9 +57,7 @@ const fetcher = (token: string, variables: any) => {
             repositories(first: 100,privacy:PUBLIC, isFork: false, ownerAffiliations: OWNER) {
               totalCount
               nodes {
-                stargazers {
-                  totalCount
-                }
+                stargazerCount
               }
               pageInfo {
                 endCursor
@@ -122,9 +120,7 @@ const coreFetcher = (token: string, variables: any) => {
             repositories(first: 100,privacy:PUBLIC, isFork: false, ownerAffiliations: OWNER) {
               totalCount
               nodes {
-                stargazers {
-                  totalCount
-                }
+                stargazerCount
               }
               pageInfo {
                 endCursor
@@ -311,9 +307,7 @@ const starsFetcher = (token: string, variables: any) => {
         user(login: $login) {
             repositories(first: 100, after: $endCursor, privacy:PUBLIC, isFork: false, ownerAffiliations: OWNER) {
               nodes {
-                stargazers {
-                  totalCount
-                }
+                stargazerCount
               }
               pageInfo {
                 endCursor
@@ -423,7 +417,7 @@ function splitFlagKey(username: string): string {
 // the profile fetch's start, not the pagination's, so the phases can't stack.
 async function paginateStars(firstPage: any, username: string, token: string, startedAt: number): Promise<number> {
     let stars: number = firstPage.nodes.reduce(
-        (acc: number, curr: {stargazers: {totalCount: number}}) => acc + curr.stargazers.totalCount,
+        (acc: number, curr: {stargazerCount: number}) => acc + curr.stargazerCount,
         0
     );
     let starsCursor: string | null = firstPage.pageInfo?.endCursor ?? null;
@@ -439,10 +433,7 @@ async function paginateStars(firstPage: any, username: string, token: string, st
         const starsRes: any = await starsFetcher(token, {login: username, endCursor: starsCursor});
         assertNoGraphQLErrors(starsRes, 'GetProfileDetails failed');
         const repos = starsRes.data.data.user.repositories;
-        stars += repos.nodes.reduce(
-            (acc: number, curr: {stargazers: {totalCount: number}}) => acc + curr.stargazers.totalCount,
-            0
-        );
+        stars += repos.nodes.reduce((acc: number, curr: {stargazerCount: number}) => acc + curr.stargazerCount, 0);
         starsCursor = repos.pageInfo?.endCursor ?? null;
         starsPages += 1;
         starsHasNextPage = shouldFetchNextPage(

tests/github-api/organization-details.test.ts

@@ -23,19 +23,19 @@ const firstPage = {
                     {
                         createdAt: '2020-01-01T00:00:00Z',
                         forkCount: 5,
-                        stargazers: {totalCount: 100},
+                        stargazerCount: 100,
                         issues: {totalCount: 3}
                     },
                     {
                         createdAt: '2021-03-15T00:00:00Z',
                         forkCount: 2,
-                        stargazers: {totalCount: 50},
+                        stargazerCount: 50,
                         issues: {totalCount: 1}
                     },
                     {
                         createdAt: '2022-06-30T00:00:00Z',
                         forkCount: 1,
-                        stargazers: {totalCount: 25},
+                        stargazerCount: 25,
                         issues: {totalCount: 0}
                     }
                 ]

tests/github-api/profile-details.test.ts

@@ -16,7 +16,7 @@ const data = {
             websiteUrl: null,
             repositories: {
                 totalCount: 30,
-                nodes: [{stargazers: {totalCount: 110}}, {stargazers: {totalCount: 20}}]
+                nodes: [{stargazerCount: 110}, {stargazerCount: 20}]
             },
             issues: {totalCount: 10},
             repositoriesContributedTo: {totalCount: 30},
@@ -342,7 +342,7 @@ describe('github api for profile details', () => {
             data: {
                 user: {
                     repositories: {
-                        nodes: [{stargazers: {totalCount: 7}}, {stargazers: {totalCount: 3}}],
+                        nodes: [{stargazerCount: 7}, {stargazerCount: 3}],
                         pageInfo: {endCursor: null, hasNextPage: false}
                     }
                 }