Repository navigation
Conversation
6458cb0 to
36a6500
Compare
Duncaen
left a comment
There was a problem hiding this comment.
Why is the duckdb change in this PR and why is it needed?
|
Also don't really like calling make from pkg_install functions, the normal practice is to do this in steps, the intsall step is installing things into destdir and then the the package step splits sub packages. |
hook previously duckdb does not have |
I may need to recheck. |
There was a problem hiding this comment.
Also don't really see the reason for the _lua_vers array, especially with things like:
for ver in ${_lua_vers[@]:1}; do
cp -a lua51 "lua${ver/./}"
done
this is just horrible to read, either just keep the 3 cp lines or make it a loop a the list in the format it needs, without extra global variables.
Seems useless to introduce all this magic just to add a new lua version every few years, especially because it always needs extra work to setup the subpackages anyways.
Testing the changes
Local build testing