Skip to content

Commit 2649c0b

Browse files
committed
Remove the unstable encodings feature
Use enabled editions to filter the default writer and golden compressor configurations. Signed-off-by: Robert Kruszewski <github@robertk.io>
1 parent a6c479b commit 2649c0b

63 files changed

Lines changed: 146 additions & 213 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

Cargo.lock

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bench-orchestrator/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,6 @@ Benchmarks are built with:
364364

365365
- Profile: `release_debug`
366366
- RUSTFLAGS: `-C target-cpu=native -C force-frame-pointers=yes`
367-
- Features: `unstable_encodings`
367+
- Features: none
368368

369369
This enables native CPU optimizations while preserving debug symbols for profiling.

bench-orchestrator/bench_orchestrator/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ class BuildConfig:
282282

283283
profile: str = "release_debug"
284284
rustflags: str = "-C target-cpu=native -C force-frame-pointers=yes"
285-
features: tuple[str, ...] = ("unstable_encodings",)
285+
features: tuple[str, ...] = ()
286286

287287

288288
def get_workspace_root() -> Path:

benchmarks/compress-bench/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ vortex-cuda = { workspace = true, optional = true }
4141
[features]
4242
cuda = ["dep:tempfile", "dep:vortex-cuda"]
4343
lance = ["dep:lance-bench"]
44-
unstable_encodings = ["vortex/unstable_encodings", "vortex-cuda?/unstable_encodings"]
4544

4645
[[bin]]
4746
name = "compress-bench"

benchmarks/compress-bench/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ Both sides therefore decode all the way to device-resident arrays, which is what
4141

4242
```bash
4343
cargo run -p compress-bench --profile release_debug \
44-
--features cuda,unstable_encodings -- --gpu-decompress
44+
--features cuda -- --gpu-decompress
4545

4646
# pick the Parquet page codec the GPU file is written with (default: snappy)
4747
cargo run -p compress-bench --profile release_debug \
48-
--features cuda,unstable_encodings -- --gpu-decompress --gpu-parquet-codec zstd
48+
--features cuda -- --gpu-decompress --gpu-parquet-codec zstd
4949
```
5050

5151
### cuDF
@@ -116,7 +116,7 @@ still publishes comparable numbers — it just takes considerably longer:
116116

117117
```bash
118118
cargo run -p compress-bench --profile release_debug \
119-
--features cuda,unstable_encodings -- --gpu-decompress --gpu-verify --iterations 1
119+
--features cuda -- --gpu-decompress --gpu-verify --iterations 1
120120
```
121121

122122
Any `--gpu-decompress` run reports on every dataset rather than stopping at the first failure, so

benchmarks/datafusion-bench/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ custom-labels = { workspace = true }
5858

5959
[features]
6060
cuda = ["dep:vortex-cuda"]
61-
unstable_encodings = ["vortex/unstable_encodings"]
6261

6362
[lints]
6463
workspace = true

benchmarks/duckdb-bench/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ vortex-duckdb = { workspace = true }
3737

3838
[features]
3939
cuda = ["dep:vortex-cuda"]
40-
unstable_encodings = ["vortex/unstable_encodings"]
4140

4241
[lints]
4342
workspace = true

benchmarks/lance-bench/Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ tokio = { workspace = true, features = ["full"] }
3030
tracing = { workspace = true }
3131
vortex-bench = { workspace = true }
3232

33-
[features]
34-
unstable_encodings = ["vortex-bench/unstable_encodings"]
35-
3633
[lib]
3734
test = false
3835

benchmarks/random-access-bench/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ vortex-bench = { workspace = true }
2727

2828
[features]
2929
lance = ["dep:lance-bench"]
30-
unstable_encodings = ["vortex-bench/unstable_encodings"]
3130

3231
[[bin]]
3332
name = "random-access-bench"

benchmarks/string-bench/Cargo.toml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,8 @@ vortex-btrblocks = { workspace = true }
3232
vortex-fsst = { workspace = true }
3333
vortex-onpair = { workspace = true }
3434

35-
[features]
36-
unstable_encodings = [
37-
"vortex/unstable_encodings",
38-
"vortex-btrblocks/unstable_encodings",
39-
]
40-
4135
[[bin]]
4236
name = "string-bench"
43-
required-features = ["unstable_encodings"]
4437

4538
[lints]
4639
workspace = true

0 commit comments

Comments
 (0)