Skip to content

feat(buffer): add allocator-backed storage - #9668

Draft
gatesn wants to merge 24 commits into
developfrom
ngates/buffer-allocator-core
Draft

feat(buffer): add allocator-backed storage#9668
gatesn wants to merge 24 commits into
developfrom
ngates/buffer-allocator-core

Conversation

@gatesn

@gatesn gatesn commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Add allocator-backed storage to vortex-buffer.

Design: vortex-data/rfcs#65

Changes

  • Use allocator_api2 for owned buffers.
  • Keep external buffers zero-copy.
  • Preserve runtime alignment and bytes/Arrow interop.
  • Add allocator-aware constructors and tests.

API Changes

Owned buffers no longer use bytes::Bytes as storage. The bytes crate remains for interop.

@gatesn gatesn mentioned this pull request Aug 27, 2026
5 tasks
@gatesn
gatesn marked this pull request as ready for review August 27, 2026 19:24
@gatesn
gatesn requested a review from AdamGS August 27, 2026 19:24
@gatesn
gatesn force-pushed the ngates/buffer-allocator-core branch from 0f5a07e to 4911c36 Compare August 27, 2026 19:38
@codspeed-hq

codspeed-hq Bot commented Aug 27, 2026

Copy link
Copy Markdown

Merging this PR will regress 18 benchmarks

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 85 improved benchmarks
❌ 18 regressed benchmarks
✅ 2029 untouched benchmarks
⏩ 164 skipped benchmarks1
🗄️ 5 archived benchmarks run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime arrow_checked_add_u32_neon[16384] 12.4 µs 20.5 µs -39.27%
Simulation decompress[u16, (4000, 256)] 37.6 µs 56.5 µs -33.44%
Simulation execute_scalar_struct_simple 111.3 µs 167.2 µs -33.41%
Simulation chunked_opt_bool_into_canonical[(1000, 10)] 85.8 µs 119.7 µs -28.34%
Simulation compact_sliced[(2048, 10)] 183.5 µs 253.7 µs -27.69%
WallTime lanezip_checked_add_u32_avx512[16384] 3.5 µs 4.5 µs -23.13%
Simulation runend_compress_u32 397.8 µs 490.4 µs -18.88%
Simulation compress[(10000, 4)] 497.5 µs 605.8 µs -17.89%
Simulation non_nullable[32] 262.7 µs 313.4 µs -16.15%
Simulation nullable[32] 264.4 µs 315.2 µs -16.12%
Simulation nullable[256] 259.1 µs 306.8 µs -15.54%
Simulation nullable[2] 365.6 µs 432.9 µs -15.53%
Simulation non_nullable[256] 258 µs 305.4 µs -15.52%
Simulation non_nullable[2] 365.1 µs 431.8 µs -15.45%
Simulation push_n_vortex_buffer[u16, 128] 2.6 µs 3 µs -12.82%
Simulation push_n_vortex_buffer[u32, 128] 2.8 µs 3.2 µs -12.39%
Simulation compact_sliced[(1024, 10)] 115.3 µs 129.8 µs -11.15%
Simulation cold_misaligned[(16, 64)] 342.3 µs 383.9 µs -10.84%
Simulation slice_tight_loop_vortex[65536] 120.7 µs 66.4 µs +81.76%
Simulation bitwise_and_vortex_buffer[128] 6.3 µs 3.7 µs +68.39%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/buffer-allocator-core (140f2c1) with develop (97953be)

Open in CodSpeed

Footnotes

  1. 164 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 5 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

@gatesn
gatesn force-pushed the ngates/buffer-allocator-core branch 2 times, most recently from 85d55a8 to 94c47cb Compare August 27, 2026 21:38
@gatesn gatesn added the changelog/feature A new feature label Aug 27, 2026
Comment thread vortex-buffer/src/buffer.rs Outdated
@gatesn
gatesn force-pushed the ngates/buffer-allocator-core branch 7 times, most recently from 7ed68a3 to 235c4c8 Compare August 29, 2026 02:45
gatesn added 14 commits August 31, 2026 09:49
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
This reverts commit 1186945.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
This reverts commit b553828.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
gatesn added 3 commits August 31, 2026 09:49
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn
gatesn force-pushed the ngates/buffer-allocator-core branch from 235c4c8 to b331ab8 Compare August 31, 2026 13:49
@gatesn
gatesn marked this pull request as draft August 31, 2026 14:29
gatesn added 7 commits August 31, 2026 11:05
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants