Skip to content

Support run-end canonicalize for decimals - #9707

Merged
danking merged 1 commit into
developfrom
dk/runend-decimal-canonicalize
Aug 31, 2026
Merged

Support run-end canonicalize for decimals#9707
danking merged 1 commit into
developfrom
dk/runend-decimal-canonicalize

Conversation

@danking

@danking danking commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add Decimal dispatch in RunEnd canonicalization
  • decode run-end Decimal values into DecimalArray while preserving precision, scale, and validity
  • add regression coverage for nullable and non-null decimal runs

Tests

  • cargo +nightly fmt --all
  • cargo test -p vortex-runend

@danking
danking enabled auto-merge (squash) August 31, 2026 22:48
@danking
danking requested review from gatesn, joseph-isaacs and robert3005 and removed request for gatesn and joseph-isaacs August 31, 2026 22:48
@danking
danking requested a review from gatesn August 31, 2026 22:48
Signed-off-by: Daniel King <dan@spiraldb.com>
@danking
danking force-pushed the dk/runend-decimal-canonicalize branch from 2b08fb5 to dbb9b88 Compare August 31, 2026 22:51
@danking danking added the changelog/feature A new feature label Aug 31, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 31, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 18.79%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 14 regressed benchmarks
✅ 2074 untouched benchmarks
⏩ 206 skipped benchmarks1
🗄️ 4 archived benchmarks run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime add_shapes_neon[(128, PerRowPerRow)] 1.8 µs 4 µs -54.36%
WallTime subtract_shapes_neon[(128, PerRowPerRow)] 1.9 µs 3.2 µs -39.71%
WallTime multiply_shapes_neon[(128, PerRowPerRow)] 2 µs 3.2 µs -38.97%
WallTime arrow_checked_add_u32_neon[16384] 12.4 µs 20.3 µs -38.94%
WallTime add_i64_nullable_neon 11.4 µs 14.7 µs -22.83%
Simulation cached_indices_i128[0.01] 48 µs 61.7 µs -22.14%
WallTime add_i32_nonnull_neon 7.9 µs 9.5 µs -16.44%
WallTime add_u32_nonnull_neon 6.6 µs 7.7 µs -13.84%
WallTime add_i64_nonnull_neon 9.8 µs 11.2 µs -13.01%
WallTime add_constant_shapes_neon[(16384, PerRowNullableConstant)] 9.8 µs 11.2 µs -12.5%
WallTime add_shapes_neon[(16384, PerRowPerRow)] 9.9 µs 11 µs -10.77%
WallTime subtract_shapes_neon[(16384, PerRowPerRow)] 9.8 µs 10.9 µs -10.65%
WallTime add_constant_shapes_neon[(16384, ConstantPerRow)] 9.2 µs 10.3 µs -10.28%
Simulation compress_fsst[(500, 64, 8)] 482.1 µs 536.2 µs -10.09%
Simulation cached_indices_i32[0.01] 51.6 µs 37.5 µs +37.36%
WallTime arrow_checked_add_u32_avx2[16384] 21.3 µs 17.7 µs +20%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing dk/runend-decimal-canonicalize (dbb9b88) with develop (97953be)

Open in CodSpeed

Footnotes

  1. 206 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

@danking
danking merged commit a67cd1b into develop Aug 31, 2026
96 of 98 checks passed
@danking
danking deleted the dk/runend-decimal-canonicalize branch August 31, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants