Skip to content

Push runend lists into listview slots - #9709

Closed
danking wants to merge 1 commit into
dk/runend-list-canonicalizefrom
dk/runend-listview-pushdown
Closed

Push runend lists into listview slots#9709
danking wants to merge 1 commit into
dk/runend-list-canonicalizefrom
dk/runend-listview-pushdown

Conversation

@danking

@danking danking commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • rewrite RunEnd canonicalization as a ListView with RunEnd offsets and sizes slots
  • preserve the elements child without eager list metadata expansion
  • add a regression test that offsets and sizes stay RunEnd after canonicalizing to ListView

Stack

Tests

  • cargo test -p vortex-runend test_runend_list -- --nocapture
  • cargo test -p vortex-runend
  • cargo clippy -p vortex-runend --all-targets --all-features
  • cargo +nightly fmt --all

Signed-off-by: Daniel King <dan@spiraldb.com>
@danking danking added the changelog/feature A new feature label Aug 31, 2026
@danking
danking requested review from gatesn and robert3005 August 31, 2026 23:14
@danking danking closed this Aug 31, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 31, 2026

Copy link
Copy Markdown

Merging this PR will regress 4 benchmarks

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 4 regressed benchmarks
✅ 2082 untouched benchmarks
⏩ 206 skipped benchmarks1
🗄️ 4 archived benchmarks run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cached_indices_i32[0.01] 37.5 µs 51.6 µs -27.2%
WallTime arrow_checked_add_u32_avx512[16384] 17.7 µs 21.4 µs -17.47%
WallTime arrow_checked_add_u32_avx2[16384] 17.7 µs 21.3 µs -16.74%
Simulation cold_misaligned[(16, 64)] 345.2 µs 389.9 µs -11.48%
WallTime arrow_checked_add_u32_neon[16384] 20.3 µs 12.2 µs +66.1%
Simulation cached_indices_i128[0.01] 61.6 µs 47.9 µs +28.79%
WallTime words_gather_scalar_avx2[65536] 9.4 µs 8.2 µs +13.7%
Simulation compress_fsst[(500, 64, 8)] 536.2 µs 481.5 µs +11.36%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing dk/runend-listview-pushdown (4945d6a) with dk/runend-list-canonicalize (cec8d20)3

Open in CodSpeed

Footnotes

  1. 206 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

  3. No successful run was found on dk/runend-list-canonicalize (97953be) during the generation of this report, so 74ec490 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@robert3005

Copy link
Copy Markdown
Contributor

I think this is probably what you want here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants