fix: stop LocalBackend execute hanging on Windows date/time - #108
Open
khuzaymahbinharis-jpg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEVNULLfor foregroundLocalBackend.execute()andasync_execute(), matching the existing background-process behavior.dateandtimefrom blocking until the execution timeout.Fixes #103
Why
On Windows, commands run through
cmd /c. Baredateandtimeare interactive commands: after displaying the current value, they wait for user input.LocalBackenddoes not expose stdin to callers, so foreground executions should be non-interactive. PassingDEVNULLcauses these commands to receive EOF immediately rather than hanging until timeout.Testing
Passed:
uv run ruff check .uv run ruff format --check .DEVNULLregression testsdate/timeregression testsOn Windows,
dateandtimenow return immediately rather than waiting for the configured execution timeout.The broader test/typecheck commands expose existing Unix-specific assumptions when run on Windows, including Unix commands/filesystem behavior such as
sleep,pwd,os.chown, Unix permissions and/tmp. These failures are unrelated to this change.