Minor clarifications - observation - #486
Open
dr-shorthair wants to merge 9 commits into
Open
Conversation
ldesousa
approved these changes
Aug 31, 2026
| of this class or its sub-classes. | ||
| Their descriptions may capture the properties and characteristics of a whole class of sensors, corresponding | ||
| with the information typically found in a spec-sheet or data-sheet. | ||
| with the information typically found in a spec-sheet or datasheet. |
Contributor
There was a problem hiding this comment.
This one I don't get. I suggested before "data sheet".
Member
There was a problem hiding this comment.
Google says correct hyphenation of "a spec-sheet or datasheet" for a formal technical document --
The correct forms are spec sheet and data sheet as two separate words without hyphens, or spec-sheet and data-sheet only when used as compound modifiers directly before a noun.
Suggested change
| with the information typically found in a spec-sheet or datasheet. | |
| with the information typically found in a spec sheet or data sheet. |
Collaborator
Author
There was a problem hiding this comment.
Sorry guys, we are going round in circles here.
I asked the web and got
Since we are working in an engineering context, I chose 'datasheet'.
Member
There was a problem hiding this comment.
Fair enough. Inconsistency is the way of the English world. :-)
TallTed
reviewed
Sep 2, 2026
TallTed
reviewed
Sep 2, 2026
TallTed
reviewed
Sep 2, 2026
TallTed
reviewed
Sep 2, 2026
TallTed
reviewed
Sep 2, 2026
TallTed
reviewed
Sep 2, 2026
TallTed
reviewed
Sep 2, 2026
TallTed
reviewed
Sep 2, 2026
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
…nor-edits-observation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjustments to text, mainly in response to Carl Reed review #477