Skip to content

Commit f36dabc

Browse files
Task updates (#77)
<!-- Do not delete this section --> **AI Disclosure:** <!-- Mark *one* box by putting an 'x' between the brackets, like this: [ ] -> [x] --> - [x] I **did not** use AI for anything in this pull request. - [ ] I *did* use AI in this pull request, and I have included a statement of AI use in the commit message of *every* commit where I used AI. <!-- ↓↓↓ Add any other information about your use of AI that you wish to include here ↓↓↓ --> _____ <!-- ↓↓↓ Write the rest of your pull request below this line ↓↓↓ --> * **New Daily Task:** Nightwave: Complete daily Nightwave acts. (Closes #76) * Fixed typo: "Paladino" → "Palladino". (Closes #73) * Reworded `weekly_nightwave_complete` to say "acts" instead of "missions", because that's what they're called in game, and not all acts are missions. * Added test: task text should end with a period. * Added period to `daily_kim_parent` and `weekly_ayatan`.
2 parents 4f61c5f + 36d8795 commit f36dabc

2 files changed

Lines changed: 19 additions & 5 deletions

File tree

sources/js/tasks.json

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,12 @@
131131
}
132132
]
133133
},
134+
{
135+
"id": "daily_nightwave",
136+
"title": "Nightwave",
137+
"text": "Complete daily Nightwave acts.",
138+
"icon": "NightwaveIconSimple.png"
139+
},
134140
{
135141
"id": "daily_sortie",
136142
"title": "Sortie",
@@ -159,7 +165,7 @@
159165
{
160166
"id": "daily_kim_parent",
161167
"title": "KIM",
162-
"text": "complete daily chats with protoframes",
168+
"text": "complete daily chats with protoframes.",
163169
"location": "Base of Operations",
164170
"terminal": "POM-2 PC",
165171
"icon": "Computer.png",
@@ -315,7 +321,7 @@
315321
{
316322
"id": "weekly_nightwave_complete",
317323
"title": "Nightwave",
318-
"text": "Complete relevant weekly Nightwave missions.",
324+
"text": "Complete relevant weekly Nightwave acts.",
319325
"icon": "NightwaveIconSimple.png"
320326
},
321327
{
@@ -327,7 +333,7 @@
327333
{
328334
"id": "weekly_ayatan",
329335
"title": "Ayatan Treasure Hunt",
330-
"text": "Complete Maroo's weekly mission for an Ayatan Sculpture",
336+
"text": "Complete Maroo's weekly mission for an Ayatan Sculpture.",
331337
"icon": "Maroo.png",
332338
"location": "Maroo's Bazaar, Mars",
333339
"npc": "Maroo"
@@ -474,11 +480,11 @@
474480
"subtasks": [
475481
{
476482
"id": "weekly_iron_wake",
477-
"title": "Paladino",
483+
"title": "Palladino",
478484
"text": "Trade Riven Slivers.",
479485
"icon": "IconOmegaMod256.png",
480486
"location": "Iron Wake, Earth",
481-
"npc": "Paladino",
487+
"npc": "Palladino",
482488
"prereq": "The Chains of Harrow"
483489
},
484490
{

sources/tests/tasks.test.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,14 @@ describe("valildate task definitions", () => {
5353
}
5454
});
5555

56+
describe("task text should end with a period", () => {
57+
test.for(flatTasks)("$id", (t) => {
58+
if (t.text) {
59+
expect(t.text.slice(-1)).toEqual(".");
60+
}
61+
});
62+
});
63+
5664
const cycle_keys_for_test = Object.keys(cycles).map((i) => [i]);
5765

5866
describe("verify equal `order` lengths", () => {

0 commit comments

Comments
 (0)