Skip to content

fix: update js-yaml to 4.3.1 to resolve GHSA-5p4m-2wfm-xmqj - #284

Closed
independabot-soc2[bot] wants to merge 1 commit into
mainfrom
independabot/js-yaml-GHSA-5p4m-2wfm-xmqj
Closed

fix: update js-yaml to 4.3.1 to resolve GHSA-5p4m-2wfm-xmqj#284
independabot-soc2[bot] wants to merge 1 commit into
mainfrom
independabot/js-yaml-GHSA-5p4m-2wfm-xmqj

Conversation

@independabot-soc2

Copy link
Copy Markdown
Contributor

Hi, this is independabot — not Lili! You can ask her if you have questions, but she had no hand in generating this PR other than setting up the independabot schedule.

Please merge this PR yourself, if you approve.

BEFORE YOU MERGE

Instructions for resolving the vuln — test to make sure that nothing is broken, check compatibility, etc.

Highlight the risky code / where the dependency was used

js-yaml is a devDependency only (used transitively by eslint-plugin-github/eslint tooling), not shipped in dist/. Low runtime risk.

Special instructions for this PR

Dependabot couldn't auto-fix this alert ("Override for js-yaml@4.3.1 conflicts with direct dependency") because the package.json overrides entry was pinned to ^4.2.0, below the patched version. This PR bumps both the overrides and devDependencies entries so the resolved version can reach 4.3.1.

Unrelated pre-existing issue found while verifying (not touched here): npm install/npm ci fail with ERESOLVE due to eslint-plugin-import@2.32.0 peer range (<=9) conflicting with eslint@^10.8.0; npm run lint also fails due to an incompatible @stylistic/eslint-plugin rule name. Both predate this change (reproduced on main before this fix) and needed --legacy-peer-deps to install locally. Repo maintainers may want a separate fix for eslint/eslint-plugin-import compatibility.

AFTER YOU MERGE

None.

@dannyneira

Copy link
Copy Markdown
Member

Superseded by #285 — main couldn't npm install under eslint 10 (eslint-plugin-import peers only ≤9). That PR restores CI and includes this bump. Closing in favor of #285.

@dannyneira

Copy link
Copy Markdown
Member

Closed as superseded by #285.

@dannyneira dannyneira closed this Aug 17, 2026
dannyneira added a commit that referenced this pull request Aug 18, 2026
Replace eslint-plugin-import (eslint<=9 only) and eslint-plugin-github
(which depends on it) with eslint-plugin-import-x so npm install works
with eslint 10. Fold Dependabot updates from #279-#284.

Co-authored-by: Warp <agent@warp.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants