Repository navigation
Export assignment-scoped worker task traces to Warp and operator OTLP - #168
Merged
Merged
Conversation
Contributor
Author
|
This PR was generated with Warp. Comment |
bnavetta
approved these changes
Oct 16, 2026
bnavetta
reviewed
Oct 16, 2026
bnavetta
reviewed
Oct 18, 2026
Use ordinary OTel spans instead of a session-wide Phase registry. Stop and acknowledge local backend observation before task-root finalization on shutdown, without invoking cancellation of preserved remote work.
bnavetta
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Export worker-side task traces using assignment OTLP configuration for REMOTE-3534. Warp export works without an operator collector, including when operator tracing is unset or disabled. Both destinations receive the same span IDs, parentage and provider-level resource.
Review guide
Start with the spec, then
internal/tasktelemetry/tracing/session.goandoperator.gofor pipeline ownership.otlpcontains task authentication and export privacy.worker.goand the backends define observation boundaries, especially preserved Kubernetes Jobs and dispatch-only Command tasks.What changed
tracing.Handleowns the operator pipeline and shared resource. Task providers send spans through independent SDK batch processors. Tasks own Warp pipelines and borrow the operator processor; flushing reaches both destinations without shutting down the operator exporter. Resources and root spans usewarp.run_idand optionalwarp.execution_id, without a duplicatetask.id.OTEL_RESOURCE_ATTRIBUTESwithout projection. Operators must exclude sensitive values. Thin immutable exporter adapters sanitize errors and bind trace export cancellation.Validation
Passed locally with
GOMAXPROCS=2:go test -race -p 1 ./internal/tasktelemetry/... ./internal/workergo test -p 2 ./...go vet -p 2 ./...go build -p 2 ./...golangci-lint run(zero issues)gofmt -s -won changed Go files, thengofmt -s -l .andgit diff --check(clean)The Kubernetes shutdown regression failed against automatic cutoff because local observers remained active. It now proves acknowledgement, child-before-root completion, Unset interrupted status, no terminal remote message, preserved Jobs and a shared export deadline. Correlation and granular Docker/Kubernetes intervals retain regression coverage. HTTPS fixtures prove both signals reject operator-only CA trust and succeed with verified task-client trust. Existing tests cover dual export, task isolation, authentication, privacy and queue overflow. No live-cluster deployment was tested.
Plans: