Fix dangling reference outputFile var - #81
Merged
Conversation
5 tasks
There was a problem hiding this comment.
Pull request overview
Fixes a dangling outputFile reference in the URL request post-request parameters, which was causing invalid string state during UNIX-socket POST operations (observed as std::bad_alloc).
Changes:
- Replace
outputFilefromconst std::string&(defaulting to a temporary) to an owningstd::stringto prevent dangling references.
Comments suppressed due to low confidence (1)
include/IURLRequest.hpp:222
- This fixes a crash observed in the UNIX-socket POST path, but there doesn’t appear to be a regression test that exercises UNIX-socket requests with default
PostRequestParameters/ConfigurationParameters(existing component tests/benchmarks seem focused on HTTP URLs). Adding a focused test that calls the UNIX-socket implementation and verifies it doesn’t crash whenoutputFileis left empty would help prevent reintroducing this dangling-reference class of issue.
std::string outputFile {};
};
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jotacarma90
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wazuh/wazuh#34611
2026/02/23 11:14:17 wazuh-manager-modulesd:vulnerability-scanner[70765] eventSendReport.hpp:253 at operator()(): WARNING: EventSendReport - Engine POST failed (exception): std::bad_allocDebugging this behavior it was found that the outputFile variable during post operation on UNIX sockets has an invalid reference.
Variable inspection before the change
Variable inspection after the change
Note
We can see the string length value is zero now.