Hide Modules nav item from non-admins - #669
Open
arifulhoque7 wants to merge 1 commit into
Open
Conversation
The sidebar "Modules" section was gated only on !isFrontend, so non-admin
users (e.g. project Co-Workers) saw the Modules nav item even though the
Modules page itself denies them ("Access denied"). Gate the section on
isAdmin, matching the Administration section — module management is a
site-admin action.
Claude-Session: https://claude.ai/code/session_01PsKkoH3J6MwAvEBgd7aUvG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hides the sidebar "Modules" nav item from non-admin users. It was shown to Co-Workers even though the Modules page denies them ("Access denied").
Root cause
AppSidebar.jsx— the "Modules + Premium" section was gated only on!isFrontend; the sibling "Administration" section is gated onisAdmin.Fix
Gate the Modules section on
isAdmin(module management is a site-admin action).Verification (browser)
Co-Worker (project member): Modules nav gone;
/modulesstill denies. Admin: unchanged.Closes weDevsOfficial/pm-pro#476
https://claude.ai/code/session_01PsKkoH3J6MwAvEBgd7aUvG