When filter on [[[ ]]] then exact match and column omitted from table - #916
Open
mhdirkse wants to merge 18 commits into
Open
When filter on [[[ ]]] then exact match and column omitted from table#916mhdirkse wants to merge 18 commits into
mhdirkse wants to merge 18 commits into
Conversation
mhdirkse
marked this pull request as draft
August 21, 2026 16:40
Member
Author
|
Almost done. We should not check in that video's are always stored. I will remove that before we merge. |
Member
Author
|
The test with FF!: https://github.com/wearefrank/ladybug/actions/runs/32503916013. It is very important because we test the database storage only here. |
mhdirkse
commented
Aug 31, 2026
| addExpression(query, column + " = ?"); | ||
| searchValue = searchValue.substring(3, searchValue.length() - 3); | ||
| args.add(searchValue); | ||
| argTypes.add(Types.VARCHAR); |
Member
Author
There was a problem hiding this comment.
I do not know how to do this better. Is this OK? Should we restrict the [[[ ]]] option to string-typed fields? Do you know a way to put the correct database type for other fields?
mhdirkse
marked this pull request as ready for review
August 31, 2026 11:52
Member
Author
|
Test with FF!: https://github.com/wearefrank/ladybug/actions/runs/33389083858/job/99478286754. Please do not merge when not successful. |
Member
Author
|
Next try testing with FF!: https://github.com/wearefrank/ladybug/actions/runs/33394643921/job/99496149940. |
Member
Author
|
Failed. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.