-
Notifications
You must be signed in to change notification settings - Fork 11
When filter on [[[ ]]] then exact match and column omitted from table #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mhdirkse
wants to merge
18
commits into
master
Choose a base branch
from
exact-match
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
46a4ae8
Implement exact match in backend for DatabaseStorage
mhdirkse 7afed01
Exact filter for non-database storages
mhdirkse f6a7913
First working version
mhdirkse 96591b7
Change icon filter sphere for exact match
mhdirkse 78f4d24
Test exact filtering in ladybug-ff-cypress-test
mhdirkse db20379
Correct previous commit - temporarily always store videos
mhdirkse fc94ae2
Also test a non-string case
mhdirkse 328c9f3
Test UI of exact filtering
mhdirkse aadf266
Improve ladybug-ff-cypress-test for filtering about Application
mhdirkse 6f9c5c8
Merge branch 'master' into exact-match
mhdirkse f7694f7
Fix Cypress tests
mhdirkse 13ade50
Revert "Fix Cypress tests"
mhdirkse c6fdc23
Only store videos when test fails
mhdirkse 81c6467
Merge branch 'master' into exact-match
mhdirkse 1ace1c0
Fix Cypress tests
mhdirkse ca95374
Fix testing column application not shown but filtered on
mhdirkse 130ee3c
Correct previous commit
mhdirkse 8d560a3
Fix previous commit
mhdirkse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,3 +5,7 @@ | |
| div:hover { | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .exact { | ||
| color: red; | ||
| } | ||
20 changes: 13 additions & 7 deletions
20
ladybug-frontend/src/app/debug/active-filters/active-filters.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,18 @@ | ||
| @if (activeFilters) { | ||
| <div class="d-flex flex-row"> | ||
| @for (filter of activeFilters | dictionary; track filter; let isFirst = $first) { | ||
| @if (filter.value !== '') { | ||
| <span [attr.data-cy-active-filter]="filter.key" class="filter-container d-flex align-items-center rounded-pill px-3 py-2 text-white " | ||
| [title]="'Active filter for ' + filter.key"> | ||
| {{ safeColumnNameToLabel(filter.key) | shortenedTableHeader | titlecase }}: {{ filter.value }} | ||
| </span> | ||
| <div class="d-flex flex-row gap-2"> | ||
| @for (filter of activeFilters; track filter.metadataName; let isFirst = $first) { | ||
| <div class="filter-container d-flex align-items-center rounded-pill px-3 py-2 text-white gap-1"> | ||
| <div class="d-flex flex-row" | ||
| [attr.data-cy-active-filter]="filter.metadataName" | ||
| [title]="'Active filter for ' + filter.metadataName + exactPhrase(filter)"> | ||
| {{ safeColumnNameToLabel(filter.metadataName) | shortenedTableHeader | titlecase }}: {{ filter.shownValue }} | ||
| </div> | ||
| @if (filter.exact) { | ||
| <div class="exact" data-cy-active-filter-exact> | ||
| <i class="bi bi-eye-slash"></i> | ||
| </div> | ||
| } | ||
| </div> | ||
| } | ||
| </div> | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know how to do this better. Is this OK? Should we restrict the [[[ ]]] option to string-typed fields? Do you know a way to put the correct database type for other fields?