layout: Advance the containing block walk past boxless ancestors - #62330
Open
servo-wpt-sync wants to merge 1 commit into
Open
layout: Advance the containing block walk past boxless ancestors#62330servo-wpt-sync wants to merge 1 commit into
servo-wpt-sync wants to merge 1 commit into
Conversation
Signed-off-by: mxmgorin <102797145+mxmgorin@users.noreply.github.com>
servo-wpt-sync
force-pushed
the
servo_export_47693
branch
from
August 31, 2026 19:56
47e9429 to
ba8a806
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
containing_block_for_nodewalks up the flat tree, but assignscurrent_ancestoronly at the bottom of the loop body. The early continue for an ancestor with no layout box therefore re-reads the same flat tree parent forever. It is an infinite loop in the script thread.Testing: Two new tests in intersection-observer. Both timeout without this change.
Fixes: #45915
Reviewed in servo/servo#47693