fix: check results before reading their value (#6003)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Author: adrians5j

packages/api-core/src/features/security/roles/Installer/RolesInstaller.ts

@@ -19,6 +19,9 @@ class RolesInstallerImpl implements AppInstaller.Interface {
 
     async install(): Promise<void> {
         const rolesResult = await this.listRolesUseCase.execute();
+        if (rolesResult.isFail()) {
+            throw rolesResult.error;
+        }
         const roles = rolesResult.value;
 
         if (!roles.find(g => g.slug === "full-access")) {

packages/api-file-manager-aco/src/features/EnsureFolderIsEmptyBeforeDelete/EnsureFolderIsEmptyBeforeDelete.ts

@@ -31,6 +31,10 @@ class EnsureFolderIsEmptyBeforeDeleteImpl implements FolderBeforeDeleteEventHand
                 limit: 1
             });
 
+            if (result.isFail()) {
+                throw result.error;
+            }
+
             const { items } = result.value;
 
             return items.length > 0;

packages/api-file-manager-s3/src/graphql/S3GraphQLSchema.ts

@@ -121,6 +121,9 @@ class S3GraphQLSchemaImpl implements CoreGraphQLSchemaFactory.Interface {
                         await checkPermissions(identityContext, { rwd: "w" });
 
                         const settingsResult = await getSettings.execute();
+                        if (settingsResult.isFail()) {
+                            throw settingsResult.error;
+                        }
                         const settings = settingsResult.value;
 
                         const normalizer = createFileNormalizerFromContext(context);
@@ -155,6 +158,9 @@ class S3GraphQLSchemaImpl implements CoreGraphQLSchemaFactory.Interface {
 
                     try {
                         const settingsResult = await getSettings.execute();
+                        if (settingsResult.isFail()) {
+                            throw settingsResult.error;
+                        }
                         const settings = settingsResult.value;
 
                         const normalizer = createFileNormalizerFromContext(context);

packages/api-file-manager/src/features/file/FileUrlGenerator/SettingsFileUrlPrefixProvider.ts

@@ -20,6 +20,9 @@ class SettingsFileUrlPrefixProviderImpl implements Abstraction.Interface {
 
     private async loadPrefix(): Promise<string> {
         const result = await this.getSettings.execute();
+        if (result.isFail()) {
+            throw result.error;
+        }
         return result.value?.srcPrefix ?? "";
     }
 }

packages/api-file-manager/src/features/settings/UpdateSettings/UpdateSettingsUseCase.ts

@@ -33,6 +33,9 @@ class UpdateSettingsUseCaseImpl implements UseCaseAbstraction.Interface {
 
         // Get existing settings to merge with new data
         const existingResult = await this.getSettings.execute();
+        if (existingResult.isFail()) {
+            return Result.fail(existingResult.error);
+        }
         const existing = existingResult.value;
 
         // Prepare merged settings

packages/api-file-manager/src/graphql/FmGraphQLSchema.ts

@@ -528,6 +528,10 @@ class FmGraphQLSchema_ implements GraphQLSchemaFactory.Interface {
             return this.listModelsUseCase.execute();
         });
 
+        if (modelsResult.isFail()) {
+            throw modelsResult.error;
+        }
+
         return modelsResult.value;
     }
 }

packages/api-headless-cms-bulk-actions/src/features/DeleteEntriesBulkAction/DeleteEntriesBulkAction.ts

@@ -16,6 +16,9 @@ class DeleteEntriesBulkActionImpl implements EntriesBulkAction.Interface {
         params: EntriesBulkAction.LoadDataParams
     ): Promise<EntriesBulkAction.LoadDataResult> {
         const entriesResult = await this.listDeletedEntries.execute(model, params);
+        if (entriesResult.isFail()) {
+            throw entriesResult.error;
+        }
 
         return entriesResult.value;
     }

packages/api-headless-cms-bulk-actions/src/features/MoveToFolderBulkAction/MoveToFolderBulkAction.ts

@@ -15,6 +15,9 @@ class MoveToFolderBulkActionImpl implements EntriesBulkAction.Interface {
         params: EntriesBulkAction.LoadDataParams
     ): Promise<EntriesBulkAction.LoadDataResult> {
         const entriesResult = await this.listLatestEntries.execute(model, params);
+        if (entriesResult.isFail()) {
+            throw entriesResult.error;
+        }
 
         return entriesResult.value;
     }

packages/api-headless-cms-bulk-actions/src/features/MoveToTrashBulkAction/MoveToTrashBulkAction.ts

@@ -16,6 +16,9 @@ class MoveToTrashBulkActionImpl implements EntriesBulkAction.Interface {
         params: EntriesBulkAction.LoadDataParams
     ): Promise<EntriesBulkAction.LoadDataResult> {
         const entriesResult = await this.listLatestEntries.execute(model, params);
+        if (entriesResult.isFail()) {
+            throw entriesResult.error;
+        }
 
         return entriesResult.value;
     }

packages/api-headless-cms-bulk-actions/src/features/PublishEntriesBulkAction/PublishEntriesBulkAction.ts

@@ -24,6 +24,10 @@ class PublishEntriesBulkActionImpl implements EntriesBulkAction.Interface {
             }
         });
 
+        if (entriesResult.isFail()) {
+            throw entriesResult.error;
+        }
+
         return entriesResult.value;
     }