Skip to content

fix(admin-ui): breadcrumb cursor and height, folder dialog autofocus - #5985

Merged
adrians5j merged 3 commits into
nextfrom
claude/breadcrumb-cursor-line-height
Oct 13, 2026
Merged

adrians5j merged 3 commits into
nextfrom
claude/breadcrumb-cursor-line-height

Conversation

@adrians5j

@adrians5j adrians5j commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

What was wrong

  • Clickable breadcrumb items render as <button> without cursor-pointer. Tailwind 4's preflight sets buttons to the default arrow cursor, so the home icon and parent links showed no pointer on hover. Other admin-ui buttons (Button, IconButton) set it explicitly.
  • Labels used leading-none, a 12px line box next to the 16px icons. Text-only items ended up 16px tall and the home item 20px, so hover backgrounds had different heights across one trail. Combined with truncate (overflow: hidden), descenders in labels like "Pages" could be clipped.

What changed

  • Added cursor-pointer to the interactive item.
  • Dropped leading-none, so labels use the text-sm line height (16px), matching the icon. Every item is now 20px tall and centers on the same axis.

Verified in the admin-ui Storybook: all items are 20px tall with centered text, and links get the pointer cursor.

Folder dialog autofocus

The Create Folder and Edit Folder dialogs in the folder tree opened with nothing focused, so typing a name needed a click first. The title field now has autoFocus() in both form definitions (FolderTreePresenter.ts).

The folder dialog change is not verified in a running admin.

Workspace: wby-next8 · admin breadcrumb polish

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Folder name fields now receive focus automatically when creating or editing a folder.
  • Style
    • Interactive breadcrumb items now display a pointer cursor, making them more visibly recognizable as clickable.
    • Breadcrumb text no longer uses compact line-height styling.

Breadcrumb links rendered as buttons without cursor-pointer, so Tailwind 4's
preflight gave them the default arrow cursor. Labels used leading-none, a 12px
line box next to the 16px icon, which made text-only hover pills 4px shorter
than the home pill and let truncate clip descenders.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

🚓 Slop Cop

✅ Nothing worth flagging. The diff looks consistent with the PR's stated intent and the code-style rules.

Small, coherent PR matching its stated intent: cursor/line-height fix in Breadcrumbs and autoFocus addition in FolderTreePresenter, with no integrity or style issues found.

Automated, non-blocking heads-up from an LLM. It can be wrong — use your judgment. Regenerates on every push.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 43ca5e22-4274-4f1a-8476-19095336a27e
📥 Commits

Reviewing files that changed from the base of the PR and between 26b93b3 and 042c98b.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 297c9322-8c1e-4d44-936a-81df7ca815a9
📥 Commits

Reviewing files that changed from the base of the PR and between e139fae and 26b93b3.

📒 Files selected for processing (1)
  • packages/app-aco/src/presentation/folderTree/FolderTreePresenter.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review.

📝 Walkthrough

Breadcrumb text and interactive item classes were updated. The create-folder and edit-folder title fields now receive autofocus.

Changes: Breadcrumb styling

Layer / File(s) Summary
Update breadcrumb classes
packages/admin-ui/src/Breadcrumbs/Breadcrumbs.tsx
The breadcrumb text class removes leading-none. Interactive breadcrumb items add cursor-pointer; their muted text and transition classes remain.

Folder title autofocus

Layer / File(s) Summary
Add autofocus to folder title fields
packages/app-aco/src/presentation/folderTree/FolderTreePresenter.ts
The create-folder and edit-folder title fields add autofocus. Their labels and required validation remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 26b93

Clickable breadcrumbs show a pointer, and newly opened folder dialogs focus their title fields. No material adverse behavior is established, so the change is ready for normal checks.

Pre-merge checks · Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely summarizes the two main changes: breadcrumb cursor and line-height updates, plus folder dialog autofocus.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The Create Folder and Edit Folder dialogs opened with nothing focused, so
typing a name needed a click first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adrians5j adrians5j changed the title fix(admin-ui): pointer cursor and even item height in breadcrumbs fix(admin-ui): breadcrumb cursor and height, folder dialog autofocus Oct 13, 2026
@adrians5j
adrians5j merged commit 7bf8d9c into next Oct 13, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant