Repository navigation
fix(admin-ui): breadcrumb cursor and height, folder dialog autofocus - #5985
Conversation
Breadcrumb links rendered as buttons without cursor-pointer, so Tailwind 4's preflight gave them the default arrow cursor. Labels used leading-none, a 12px line box next to the 16px icon, which made text-only hover pills 4px shorter than the home pill and let truncate clip descenders. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🚓 Slop Cop ✅ Nothing worth flagging. The diff looks consistent with the PR's stated intent and the code-style rules. Small, coherent PR matching its stated intent: cursor/line-height fix in Breadcrumbs and autoFocus addition in FolderTreePresenter, with no integrity or style issues found. Automated, non-blocking heads-up from an LLM. It can be wrong — use your judgment. Regenerates on every push. |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
The Create Folder and Edit Folder dialogs opened with nothing focused, so typing a name needed a click first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What was wrong
<button>withoutcursor-pointer. Tailwind 4's preflight sets buttons to the default arrow cursor, so the home icon and parent links showed no pointer on hover. Other admin-ui buttons (Button,IconButton) set it explicitly.leading-none, a 12px line box next to the 16px icons. Text-only items ended up 16px tall and the home item 20px, so hover backgrounds had different heights across one trail. Combined withtruncate(overflow: hidden), descenders in labels like "Pages" could be clipped.What changed
cursor-pointerto the interactive item.leading-none, so labels use thetext-smline height (16px), matching the icon. Every item is now 20px tall and centers on the same axis.Verified in the admin-ui Storybook: all items are 20px tall with centered text, and links get the pointer cursor.
Folder dialog autofocus
The Create Folder and Edit Folder dialogs in the folder tree opened with nothing focused, so typing a name needed a click first. The title field now has
autoFocus()in both form definitions (FolderTreePresenter.ts).The folder dialog change is not verified in a running admin.
Workspace: wby-next8 · admin breadcrumb polish
🤖 Generated with Claude Code
Summary by CodeRabbit