Repository navigation
fix(website-builder): leave a deleted revision and order revisions by version - #6006
Merged
Merged
Conversation
… version Deleting the revision open in the editor left the editor on a revision that no longer existed, with the revision selector stuck on "Loading...". The revisions list now moves the editor to the newest remaining revision, or back to the pages list when none is left. The list was ordered by savedOn, so publishing or editing an older revision moved it above newer ones. It is now ordered by version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to the Website Builder revisions drawer.
RevisionsListnow moves the editor to the newest remaining revision, or back to the pages list when none is left. Deleting any other revision leaves the editor where it is.RevisionListPresenterordered revisions bysavedOn, so publishing or editing an older revision moved it above newer ones (for example Add support for table name #2, CreateEntityEndpointclass to automatically handle common CRUD methods for the definedEntity. #1, Exposing query method. #3). It now orders by version, newest first.Tests
RevisionListPresentertest for the ordering. It fails with the oldsavedOnordering and passes now; the presenter suite passes (17 tests).next, where the same fix is part of fix(website-builder): page revision cache, list actions and workflow gating #6004: deleting the open revision Exposing query method. #3 moved the editor to Add support for table name #2, deleting CreateEntityEndpointclass to automatically handle common CRUD methods for the definedEntity. #1 while on Add support for table name #2 kept the editor on Add support for table name #2, and the drawer and top-bar dropdown listed Exposing query method. #3, Add support for table name #2, CreateEntityEndpointclass to automatically handle common CRUD methods for the definedEntity. #1 before and after a reload. The 6.5.0RevisionsListkeeps the view model in React state rather than reading the presenter directly, so here the next revision is picked from the list it already holds, minus the deleted one.Workspace: wby-next2 · 🧹 MERGE 6.5.0 => NEXT
🤖 Generated with Claude Code