Skip to content

chore: remove the last Cypress leftovers - #6012

Merged
adrians5j merged 2 commits into
nextfrom
chore/remove-cypress-leftovers
Oct 15, 2026
Merged

adrians5j merged 2 commits into
nextfrom
chore/remove-cypress-leftovers

Conversation

@adrians5j

@adrians5j adrians5j commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #6010, which moved the installation test to e2e/ and removed the Cypress workspace. This removes what was left.

  • v5 /cypress command workflow. v5_PullRequestsCommandCypress.yml and its frozen generator are deleted.
  • CMS model editor title. Name.tsx turned autoFocus off when window.Cypress was set, to work around a blur during Cypress runs. In a real browser that global is undefined, so the value was always true, which is also EditableTitle's default. The check and its Window type augmentation are gone, and nothing changes for users.
  • sync-dependencies. createDependencyTree also listed workspaces under <project root>/cypress. No project has that folder, and listing the missing path returned the root's workspaces again. So references.json recorded every package.json twice: 241 of 243 dependencies had duplicate file entries before, 0 after. verify-dependencies passes.
  • New-project template. cypress.json is removed from _templates/base/example.gitignore.

Checked: @webiny/cli-core and @webiny/app-headless-cms build, lint and format are clean, adio passes, and sync-dependencies and verify-dependencies agree.

Workspace: wby-next5 · 🧪 port admin install e2e

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • The /v5_cypress pull-request command and its automated end-to-end test runs for both storage configurations have been removed.
    • Dependency checks now include the root and, when available, end-to-end test dependencies alongside package dependencies.
    • cypress.json is no longer excluded by the project’s Git ignore rules.

- Delete the v5 /cypress command workflow and its frozen generator.
- Drop the window.Cypress autofocus check from the CMS model editor's
  title. Outside Cypress it was always true, which is EditableTitle's
  default.
- Stop sync-dependencies from listing workspaces under a root
  `cypress` folder. No project has one, and listing the missing path
  returned the root's workspaces again, so references.json recorded
  every package.json twice.
- Drop cypress.json from the new-project .gitignore template.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

🚓 Slop Cop

✅ Nothing worth flagging. The diff looks consistent with the PR's stated intent and the code-style rules.

The PR cleanly matches its stated intent (removing final Cypress leftovers): large deletions are entirely in the deleted v5 Cypress workflow YAML and its generator script, and other changes (Name.tsx, createDependencyTree.ts, references.json, gitignore) are small and consistent with the description.

Automated, non-blocking heads-up from an LLM. It can be wrong — use your judgment. Regenerates on every push.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2a6db6d4-0ac1-4e8e-ac89-c8f884e40bec
📥 Commits

Reviewing files that changed from the base of the PR and between fae73c6 and 985547d.

📒 Files selected for processing: 2
  • packages/cli-core/files/references.json
  • packages/cli-core/src/features/DepsSync/createDependencyTree.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

📝 Walkthrough

The pull-request Cypress workflow and its frozen WAC source were deleted. The editor no longer checks for Cypress when setting title autofocus. Dependency discovery now includes the root manifest and, when present, the e2e manifest, and no longer scans the Cypress directory. The base template no longer ignores cypress.json.

Changes: Cypress-related changes

Layer / File(s) Summary
Pull-request Cypress workflow removal
.github/workflows/v5_PullRequestsCommandCypress.yml, .github/workflows/wac/v5_pullRequestsCommandCypress.wac.frozen.ts
Both workflow files were deleted. They contained the /v5_cypress trigger and build, setup, and Cypress test jobs for DDB and DDB-OS.
Editor and project reference updates
packages/app-headless-cms/src/admin/plugins/editor/defaultBar/Name/Name.tsx, packages/cli-core/src/features/DepsSync/createDependencyTree.ts, packages/create-webiny-project/_templates/base/example.gitignore
Name no longer checks window.Cypress or passes an autoFocus value to EditableTitle. Dependency discovery no longer scans the Cypress directory and includes the e2e manifest when it exists. The template no longer ignores cypress.json.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 98554

The Cypress cleanup and e2e dependency scan appear consistent with the stated migration, and dependency verification checks the generated tree. No specific merge-blocking behavior is identified.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately summarizes the main change: removing the remaining Cypress-related workflows, checks, and configuration leftovers.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

e2e/ shares deps with the packages (zod, ai). Including its
package.json means a version that drifts from the packages' shows up
in duplicates.json, and verify-dependencies fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adrians5j
adrians5j merged commit 4ad1726 into next Oct 15, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant