Repository navigation
chore: remove the last Cypress leftovers - #6012
Conversation
- Delete the v5 /cypress command workflow and its frozen generator. - Drop the window.Cypress autofocus check from the CMS model editor's title. Outside Cypress it was always true, which is EditableTitle's default. - Stop sync-dependencies from listing workspaces under a root `cypress` folder. No project has one, and listing the missing path returned the root's workspaces again, so references.json recorded every package.json twice. - Drop cypress.json from the new-project .gitignore template. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🚓 Slop Cop ✅ Nothing worth flagging. The diff looks consistent with the PR's stated intent and the code-style rules. The PR cleanly matches its stated intent (removing final Cypress leftovers): large deletions are entirely in the deleted v5 Cypress workflow YAML and its generator script, and other changes (Name.tsx, createDependencyTree.ts, references.json, gitignore) are small and consistent with the description. Automated, non-blocking heads-up from an LLM. It can be wrong — use your judgment. Regenerates on every push. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
e2e/ shares deps with the packages (zod, ai). Including its package.json means a version that drifts from the packages' shows up in duplicates.json, and verify-dependencies fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follow-up to #6010, which moved the installation test to
e2e/and removed the Cypress workspace. This removes what was left./cypresscommand workflow.v5_PullRequestsCommandCypress.ymland its frozen generator are deleted.Name.tsxturnedautoFocusoff whenwindow.Cypresswas set, to work around a blur during Cypress runs. In a real browser that global is undefined, so the value was alwaystrue, which is alsoEditableTitle's default. The check and itsWindowtype augmentation are gone, and nothing changes for users.sync-dependencies.createDependencyTreealso listed workspaces under<project root>/cypress. No project has that folder, and listing the missing path returned the root's workspaces again. Soreferences.jsonrecorded everypackage.jsontwice: 241 of 243 dependencies had duplicate file entries before, 0 after.verify-dependenciespasses.cypress.jsonis removed from_templates/base/example.gitignore.Checked:
@webiny/cli-coreand@webiny/app-headless-cmsbuild, lint and format are clean,adiopasses, andsync-dependenciesandverify-dependenciesagree.Workspace: wby-next5 · 🧪 port admin install e2e
🤖 Generated with Claude Code
Summary by CodeRabbit
/v5_cypresspull-request command and its automated end-to-end test runs for both storage configurations have been removed.cypress.jsonis no longer excluded by the project’s Git ignore rules.