Repository navigation
test(e2e): move the installation test to e2e and remove Cypress (6.5.0) - #6013
Merged
Merged
Conversation
Ports #6010 and the cleanups from #6012 to 6.5.0. The installation wizard test now lives in a new `e2e/` workspace (TesterArmy's e2e framework with Playwright), and the Cypress workspace, its config template, setup scripts and root scripts are gone. The e2e workspace only carries what the installation test needs. There is no AI agent config, so `ai`, `@ai-sdk/anthropic` and `zod` are left out; `ai` is an optional peer of `e2e`. The lockfile pins `e2e` 0.15.1, `@e2e-dev/web` 0.11.1 and `playwright` 1.63.0, the versions next resolves. A fresh resolve picked `@e2e-dev/web` 0.11.2, which fails to load against `e2e` 0.15.2. CI: the `/e2e` command and the push E2E jobs (DDB and DDB+OS) run `E2E_INSTALLATION=1 yarn e2e --tag installation` against the deployed Admin app URL and upload `e2e/.e2e/` on failure. The type-check step runs `yarn e2e:ts` instead of `yarn cy:ts`. The `/e2e` comment no longer says Cypress. Also removed: the v5 `/cypress` command workflow, the `window.Cypress` autoFocus check in the CMS model editor title (`EditableTitle` already defaults to `autoFocus`), the `<project root>/cypress` folder that made `sync-dependencies` list every package.json twice, and `cypress.json` in the new-project .gitignore template. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces Cypress with the e2e framework on
release/6.5.0, keeping only the installation test. This is the 6.5.0 counterpart of #6010 onnext, plus the leftover cleanups from #6012.Added
e2e/workspace (e2e-tests) withtests/installation.e2e.ts: a freshly deployed project installs through the wizard and the admin lands on the dashboard. The test is the same as onnext; 6.5.0's wizard has the same labels and buttons.e2e.config.tshas the admin target and credentials only. With no agent steps there is no model, so no AI dependencies and no API key.e2e,e2e:headedande2e:ts. The type-check step inpullRequestsandpushrunsyarn e2e:ts.Removed
cypress-tests/workspace,example.cypress.config.ts,scripts/setupCypress.js,scripts/listCypressTestsFolders.js, thecy:*,cypress:*andsetup-cypressscripts, and the Cypress lines inexample.env,.gitignoreandtsconfig.build.json./cypresscommand workflow and its generator.window.Cypresscheck in the CMS model editor title (Name.tsx). It always resolved toautoFocus: true, which isEditableTitle's default, so nothing changes for users.<project root>/cypresslisting increateDependencyTree. It returned the root's workspaces a second time, soreferences.jsonlisted everypackage.jsontwice (252 of 254 dependencies had duplicate entries, 0 now).cypress.jsonin the new-projectexample.gitignore. The Cypress section ofdocs/CONTRIBUTING.mdis replaced by a short e2e paragraph.CI
/e2e(AWS, DDB and DDB+OS) runs the installation test instead of the Cypress installation spec: it installs Playwright Chromium, runsyarn e2e --tag installationagainst the deployed Admin, and uploadse2e/.e2eon failure. The steps come fromnext'screateInstallationTestSteps.pushgets the same change. The commented-out Cypress matrix job is gone.pullRequests.yml,pullRequestsCommandE2e.ymlandpush.yml.Tests
e2e listcollects the installation test; it's skipped unlessE2E_INSTALLATION=1, as onnext.yarn e2e:ts,adio, oxfmt and oxlint pass./e2eon this PR is the real check.Notes:
yarn.lockresolvese2e0.15.1 and@e2e-dev/web0.11.1, the versionsnextuses. The newest releases (0.15.2 and 0.11.2) don't load together.docs/gh-actions-workflows/, which are for users' projects and stay onnexttoo, and the transitive@cypress/request.Workspace: wby-next2 · 🧹 MERGE 6.5.0 => NEXT
🤖 Generated with Claude Code