Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation is complete and tested; only a non-blocking documentation grammar correction remains.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds an opt-in parser token limit to protect parsing resources.
Changes:
- Centralizes lexer advancement and token counting.
- Throws
SyntaxErrorwhenmaxTokensis exceeded. - Adds boundary/default-limit tests and changelog documentation.
| File | Description |
|---|---|
src/Language/Parser.php |
Implements and documents maxTokens. |
tests/Language/ParserTest.php |
Tests limits and unlimited defaults. |
CHANGELOG.md |
Records the new option. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+106
to
+108
| * Parser CPU and memory usage is linear to the number of tokens in a document, | ||
| * and parsing happens before validation, so even an invalid document can use a lot of resources. | ||
| * Set this option to limit the number of tokens a document may contain, parsing then fails with a syntax error. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1905.
Adds the
maxTokensparser option from graphql-js (graphql/graphql-js#3684): the parser counts the tokens it consumes and throws aSyntaxErroronce the document exceeds the limit. There is no limit by default.All the
Lexer::advance()calls of the parser now go through a singleadvanceLexer()method that does the counting, as in the reference implementation. The error message follows the current graphql-js wording ("more than", the original "more that" typo was fixed there), and the graphql-js test is ported with its@see it(...)annotation.Changelog
Added
maxTokensparser option to limit the number of tokens a document may contain Add maxTokens option to Parser #1905