Repository navigation
fix: don't count modules inside found directories twice in search total - #743
Conversation
🦋 Changeset detectedLatest commit: cb1d322 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Walkthrough
Priority: ⬇️ Low Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: preventing modules inside matched directories from being counted twice in search totals. Linked Issues check Issue #251requires the search total to avoid adding a matched directory and its matched descendants twice.client/store.jsnow traverses each chunk tree and stops at the first found node. `test/sto…Out of Scope Changes check The changes stay within issue #251. The new store tests verify the counting behavior, and.changeset/fix-search-total-size.mddocuments the matching patch release. No unrelated product behavior is c…Full details: Linked Issues check
-
Explanation
Issue
#251requires the search total to avoid adding a matched directory and its matched descendants twice.client/store.jsnow traverses each chunk tree and stops at the first found node.test/store.jscovers directory, module, and mixed matches, includinglodash|findwith an expected size of 30.
Full details: Out of Scope Changes check
-
Explanation
The changes stay within issue
#251. The new store tests verify the counting behavior, and.changeset/fix-search-total-size.mddocuments the matching patch release. No unrelated product behavior is changed.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
🔧 ESLint
-
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
ESLint install timed out. The project may have too many dependencies for the sandbox.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
Could you sign the CLA? |
|
Signed |
valscion
left a comment
valscion
left a comment
There was a problem hiding this comment.
Thanks, looks good to me!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
==========================================
- Coverage 89.92% 87.49% -2.44%
==========================================
Files 17 20 +3
Lines 1132 1271 +139
Branches 420 444 +24
==========================================
+ Hits 1018 1112 +94
- Misses 105 146 +41
- Partials 9 13 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fixes #251
foundModulesSizesummed every match, so when a directory and modules inside it both matched (e.g. searchinglodash), the modules were counted once in the directory's size and again on their own. It now walks the tree and stops at the first found node, as suggested in #251 (comment).Added
test/store.jscovering directory, module and mixed matches (fails on main with 60 instead of 30).npm testandnpm run lintpass.Written with help from an AI coding assistant.
Summary by CodeRabbit