Skip to content

Fix/context menu theme - #744

Open
ronakmaheshwari wants to merge 2 commits into
webpack:mainfrom
ronakmaheshwari:fix/context-menu-theme
Open

ronakmaheshwari wants to merge 2 commits into
webpack:mainfrom
ronakmaheshwari:fix/context-menu-theme

Conversation

@ronakmaheshwari

@ronakmaheshwari ronakmaheshwari commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Context:
Follow-up to #690. The context menu still had hard-coded colors, and disabled items were low contrast in both themes

What changed:
This applies the same CSS changes that were already discussed and reviewed there based on the work done by @theEquinoxDev, so it should be easy to merge:

  1. Menu background and border use --bg-primary and --border-color
  2. Disabled items use --text-secondary
  3. Hover and click behavior is unchanged

Summary by CodeRabbit

  • Style
    • Context menus now use theme-based background, border, and disabled-text colors.
    • Disabled menu items appear with reduced opacity.

@changeset-bot

changeset-bot Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 166657c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
webpack-bundle-analyzer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ronakmaheshwari

Copy link
Copy Markdown
Contributor Author

@evenstensberg can u just take a look

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e80b42bf-0491-455b-a3f6-414df7f5a64c
Commits

Reviewing files that changed from the base of the PR and between 0932a15 and 166657c.

Files selected for processing: 1
  • .changeset/fix-context-menu-theme.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The context menu container now uses CSS variables for its background and border colors. Disabled context menu items now use the secondary text color and have reduced opacity. A patch changeset records the color updates.

Priority: Low

Merge Risk: Minimal · up to 16665

No concrete merge-blocking issue is established for these styling and release-note changes. Merge after normal checks pass.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: fixing the context-menu theme. It is concise and related to the changeset.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

"webpack-bundle-analyzer": minor
---

Use Webpack's infrastructure logger when available (`compiler.getInfrastructureLogger('webpack-bundle-analyzer')`) and deprecate the plugin's `logLevel` option in favor of Webpack's native `infrastructureLogging` configuration.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changeset appearing in this diff is likely a result of @ronakmaheshwari your branch being a bit stale.

Otherwise this change looks good. Can you show a screenshot of before and after and then I can approve it once we have the correct changeset also in here?

I'd like to spell this out as a small fix in the release notes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes done, Changes done @valscion can you verify it

Before:-
before-dark-menu
before-dark
before-light-menu
before-light

After:-
after-dark-menu
after-dark
after-light-menu
after-light

@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.92%. Comparing base (0ebe1e5) to head (0932a15).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #744   +/-   ##
=======================================
  Coverage   89.92%   89.92%           
=======================================
  Files          17       17           
  Lines        1132     1132           
  Branches      420      420           
=======================================
  Hits         1018     1018           
  Misses        105      105           
  Partials        9        9           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants