Repository navigation
Fix/context menu theme - #744
ronakmaheshwari wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 166657c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@evenstensberg can u just take a look |
|
No actionable comments were generated in the recent review.
|
| "webpack-bundle-analyzer": minor | ||
| --- | ||
|
|
||
| Use Webpack's infrastructure logger when available (`compiler.getInfrastructureLogger('webpack-bundle-analyzer')`) and deprecate the plugin's `logLevel` option in favor of Webpack's native `infrastructureLogging` configuration. |
There was a problem hiding this comment.
This changeset appearing in this diff is likely a result of @ronakmaheshwari your branch being a bit stale.
Otherwise this change looks good. Can you show a screenshot of before and after and then I can approve it once we have the correct changeset also in here?
I'd like to spell this out as a small fix in the release notes.
There was a problem hiding this comment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
=======================================
Coverage 89.92% 89.92%
=======================================
Files 17 17
Lines 1132 1132
Branches 420 420
=======================================
Hits 1018 1018
Misses 105 105
Partials 9 9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0932a15 to
166657c
Compare








Context:
Follow-up to #690. The context menu still had hard-coded colors, and disabled items were low contrast in both themes
What changed:
This applies the same CSS changes that were already discussed and reviewed there based on the work done by @theEquinoxDev, so it should be easy to merge:
Summary by CodeRabbit