Skip to content

fix: ensure consistent asset filtering with global regular expressions #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DarshanaChandel wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: ensure consistent asset filtering with global regular expressions #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ece1b3d
fix: reset global regex state in asset filters
DarshanaChandel Oct 20, 2026
bf334da
test: correct global regex filter expectations
DarshanaChandel Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ function createAssetsFilter(excludePatterns) {
* @param {string} asset asset
* @returns {boolean} true when need to exclude, otherwise false
*/
(asset) => pattern.test(asset)
(asset) => {
pattern.lastIndex = 0;
return pattern.test(asset);
}
);
}

Expand Down
7 changes: 7 additions & 0 deletions test/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@
expect(filter("bar")).toBe(true);
expect(filter("bar-foo")).toBe(true);
});
it("should consistently filter assets with global RegExp patterns", () => {

Check failure on line 27 in test/utils.js

View workflow job for this annotation

GitHub Actions / lint 

Expected blank line before this statement

Check failure on line 27 in test/utils.js

View workflow job for this annotation

GitHub Actions / lint 

Insert `··`
const filter = createAssetsFilter(/\.js/g);

Check failure on line 28 in test/utils.js

View workflow job for this annotation

GitHub Actions / lint 

Insert `··`

expect(filter("main.js")).toBe(false);

Check failure on line 30 in test/utils.js

View workflow job for this annotation

GitHub Actions / lint 

Insert `··`
expect(filter("main.js")).toBe(false);

Check failure on line 31 in test/utils.js

View workflow job for this annotation

GitHub Actions / lint 

Insert `··`
expect(filter("main.js")).toBe(false);

Check failure on line 32 in test/utils.js

View workflow job for this annotation

GitHub Actions / lint 

Replace `··` with `····`
});

Check failure on line 33 in test/utils.js

View workflow job for this annotation

GitHub Actions / lint 

Insert `··`

it("should allow a filter function as a pattern", () => {
const filter = createAssetsFilter((asset) => asset.startsWith("foo"));
Expand Down
Loading