Fix EGL error code reporting in GLException messages - #213
Open
NamtarR wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In all cases when
GLExceptionis thrown,eglGetError()is being called twice - once for the exception constructor and once for the error message. SinceeglGetError()clears the error state after being called, the second call always returnsEGL_SUCCESSinstead of the actual error code. While debugging locally, it is still possible to retrieve the initial error code from the exception object, but it gets completely lost when the exception is reported to crash reporting tools like Crashlytics. This unintentional masking of the real error makes debugging such cases more difficult than it should be. There are several issues in livekit-android with the same problem as well.Solution
Extract a
throwEglExceptionhelper method that accepts the error code as a parameter. CalleglGetError()only once at each call site and pass the result tothrowEglException.