feat: Soften duplicate contract name in the case contracts have identical ABIs - #4694
feat: Soften duplicate contract name in the case contracts have identical ABIs#4694silasdavis wants to merge 1 commit into
Conversation
…ical ABIs This is useful for instance when contracts appear as duplicates when ingesting from a single Foundry project that depends on others foundry projects. In this case `getArtifactPaths()` in the Foundry plugin pick up the same contracts twice since they end up existing in both `out/` directories. I don't think there is a reliable to heuristic to de-duplicate them at this level. It seems like duck-typing contracts by the ABI should be fine, it could always be enabled via an option. Signed-off-by: Silas Davis <silas@inco.network>
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
silasdavis
changed the title
|
I just want to put this out for a sense check before going to town on the rest of contribution requirements, let me know what you think. |
|
closing for correct description of root cause after debugging some more: #4695 |
1 participant
This is useful for instance when contracts appear as duplicates when ingesting from a single Foundry project that depends on others foundry projects.
In this case
getArtifactPaths()in the Foundry plugin pick up the same contracts twice since they end up existing in bothout/directories. I don't think there is a reliable to heuristic to de-duplicate them at this level.It seems like duck-typing contracts by the ABI should be fine, it could always be enabled via an option.