fix(core): catch connector.isAuthorized() rejection in reconnect and revalidate - #5235
Open
lx3133584 wants to merge 1 commit into
Open
fix(core): catch connector.isAuthorized() rejection in reconnect and revalidate#5235lx3133584 wants to merge 1 commit into
lx3133584 wants to merge 1 commit into
Conversation
|
@lx3133584 is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
|
…revalidate Signed-off-by: Liang Xu <lx3133584@users.noreply.github.com>
lx3133584
force-pushed
the
fix/reconnect-catch-is-authorized-rejection
branch
from
August 28, 2026 21:11
8dc47b9 to
8eaa20a
Compare
cultosagent
added a commit
to cultosagent/dogma-registry
that referenced
this pull request
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a connector's
isAuthorized()method throws or rejects (e.g. stale WalletConnect session, unreachable relay, or transport network failure),reconnect()andcreateConfig'srevalidate()fail unhandled. This left the config state permanently stranded in thereconnectingstatus and kept the internalisReconnectinglock flagtrue, preventing all subsequent reconnection attempts from running.Cause
reconnect()andcreateConfig.revalidate()awaitedconnector.isAuthorized()without a.catch()handler, unlike neighboringconnector.getProvider()andconnector.connect(). A thrown rejection propagated out of the function beforeisReconnectingcould be reset and beforeconfig.setStatecould update the status todisconnected.Fix
.catch(() => false)toconnector.isAuthorized()inpackages/core/src/actions/reconnect.tsandpackages/core/src/createConfig.ts.reconnectin atry ... finallyblock to guaranteeisReconnectingis reset tofalseeven if unexpected errors occur.state.connectionsduringrevalidate()with a freshMapcopy so state subscribers receive proper updates.Testing
packages/core/src/actions/reconnect.test.tsandpackages/core/src/createConfig.test.tsverifying thatreconnectandrevalidaterecover gracefully whenisAuthorizedrejects and allow subsequent reconnect calls to succeed.