Skip to content

Commit df7a707

Browse files
committed
Bug fix (in case of unknown program/args for a task)
1 parent 257db3b commit df7a707

1 file changed

Lines changed: 21 additions & 15 deletions

File tree

wfcommons/wfinstances/logs/snakemake.py

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -214,23 +214,29 @@ def _create_tasks(self):
214214

215215
if self.task_shell[idx]:
216216
program_name = self.task_shell[idx].split(' ')[0]
217-
# program_args = self.task_shell[idx].split(' ')[0:]
218217
program_args = shlex.split(self.task_shell[idx], posix=False)
218+
task = Task(name=self.task_map[idx],
219+
task_id=self.task_map[idx],
220+
task_type=TaskType.COMPUTE,
221+
runtime=elapsed,
222+
executed_at=start_date,
223+
input_files=input_files,
224+
output_files=output_files,
225+
program=program_name,
226+
cores=self.task_threads[idx],
227+
args=program_args,
228+
logger=self.logger)
219229
else:
220-
program_name = "n/a"
221-
program_args = []
222-
223-
task = Task(name=self.task_map[idx],
224-
task_id=self.task_map[idx],
225-
task_type=TaskType.COMPUTE,
226-
runtime=elapsed,
227-
executed_at=start_date,
228-
input_files=input_files,
229-
output_files=output_files,
230-
program=program_name,
231-
cores=self.task_threads[idx],
232-
args=program_args,
233-
logger=self.logger)
230+
task = Task(name=self.task_map[idx],
231+
task_id=self.task_map[idx],
232+
task_type=TaskType.COMPUTE,
233+
runtime=elapsed,
234+
executed_at=start_date,
235+
input_files=input_files,
236+
output_files=output_files,
237+
cores=self.task_threads[idx],
238+
logger=self.logger)
239+
234240
self.workflow.add_task(task)
235241

236242
# File dependencies

0 commit comments

Comments
 (0)