Repository navigation
chains: recognise plain UTC as a timezone in proposed spans - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chains/spans.pymatches named zones with[A-Z]{2,4}T\b, which coversGMT,CEST,ESTand the rest, plusutc±Nfor offsets. PlainUTCdoesn't end inT, so it never matches, even thoughZONESmaps"utc": 0.So a UTC time stays naive: it ranks last for
prefer="with_zone"slots, notimezonespan is offered, andopscan't place it against zoned times.Change: add
utc\bto_ZONE_RE, after theutc±Nalternative soUTC+2still matches whole.Test:
test_propose_plain_utc_is_a_zonecovers a plain-UTCdatetime next to aUTC+2one (zones, span text, andtimezonespans). It fails onmainand passes with this change.I also ran the other test files one at a time (backends, calibrate, clef_head, device, fanout, jevcompat_issue16, noul_band, patterns_presets, server, train_write_json, version_lockstep), and they all pass.
test_client,test_openjev_compatibilityandtest_primitivesdidn't finish on this machine within the time limit, and none of them importchains.