Replace npm with yarn; add CI workflow to run TSC and tslint checks - #699
Replace npm with yarn; add CI workflow to run TSC and tslint checks#699laurence-myers wants to merge 12 commits into
npm with yarn; add CI workflow to run TSC and tslint checks#699Conversation
…h tsconfig file. Fix resulting identified issues.
…cycle-interface`. Fixes a warning in CI.
> Could not find implementations for the following rules specified in the configuration:
use-life-cycle-interface
> Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
> Lint was recently upgraded, you may have old rules configured which need to be cleaned up.
mgechev/codelyzer#791 (comment)
|
Thank you for the contribution! I'll give it a try on Mac and Windows to see how it goes. I remember when I'm not opposed to merging this -- I'll try it out first 🙇 |
Yep, I'd be happy to stick with Plus, I noticed If you look at the number of lines changed, this MR removes approx 30,000 lines. Maybe it's because |
|
Thank you again @laurence-myers for this PR 🙇♂️ I'm releasing version |
To avoid linting issue sneaking in, particularly in the backend/server code, I've added a GitHub Action workflow to run
tscandtslinton every push.yarnbehaves better across different execution environments. In particular,npm cifailed to run in a GitHub Action, due tofseventsbeing a required dependency (somehow).Example CI check:
https://github.com/laurence-myers/Video-Hub-App/runs/3578230215?check_suite_focus=true
This PR is based on #698, and includes its changes.