Skip to content

Added new settings buttons to toggle visibility of most meta data - #897

Open
VarunAdhav wants to merge 2 commits into
whyboris:mainfrom
VarunAdhav:feature/metaRedesign-843
Open

Added new settings buttons to toggle visibility of most meta data#897
VarunAdhav wants to merge 2 commits into
whyboris:mainfrom
VarunAdhav:feature/metaRedesign-843

Conversation

@VarunAdhav

Copy link
Copy Markdown

The issue I have addressed: #843

What I Did

  • Individual toggle buttons were implemented to control the visibility of key video metadata fields.
  • Added toggles for:
    • Duration
    • Resolution
    • File Size
    • Bitrate
    • FPS
    • Year
    • Ratings (Star Rating)
  • Default behavior remains unchanged unless toggles are used.

@whyboris

Copy link
Copy Markdown
Owner

❤️ what tremendous work! 🙇‍♂️

Thank you so much @VarunAdhav 😁 -- I'll definitely try to merge this in some capacity (I'm picky about UI stuff so I might nudge things around). I'm hoping to get some VHA release put together around August, so I might get to reviewing this PR around then; thank you for your patience.

Cheers! 😊

@VarunAdhav

Copy link
Copy Markdown
Author

Thank you ✌🏻.

@whyboris

Copy link
Copy Markdown
Owner

Thank you @VarunAdhav for the contribution 🙇

I unfortunately updated a bunch of files to how Angular recommends for its newer versions before merging in PRs 😓 Because of that, your PR has a bunch of merge conflicts. I'm happy to reconcile them, but I'm really eager to get 3.3.0 released 😅 so I'm going to keep this PR open for later when I have time to go through the changes manually.

I tested out your code - it works great 👍 I intend to merge it / some version of it for the subsequent release of VHA 🤝

@VarunAdhav

Copy link
Copy Markdown
Author

Thank you @whyboris for taking the time to test it and I am happy to hear that it works fine!!

@whyboris

Copy link
Copy Markdown
Owner

Intending to get some version of this released after 3.3.0 is released 👍

Related: #633

I'm intending to try to consolidate requests from #633 into this/similar change 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants