fix: sync local changes, fix vercel-domains spec for CI - #37
Merged
Conversation
- Fix vercel-domains.service.spec.ts: getOrThrow → get (matches service change) - Sync all uncommitted local backend changes to repo - Add vercel.json scoping build to apps/web only - Clean up test results artifacts Verified: backend builds, 528 tests pass, frontend builds clean. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The vercel.json set framework: "nextjs" at the root but next isn't in the root package.json. Vercel was already detecting apps/web correctly via project settings. Removing to restore working behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Test was checking for electricianprep.vercel.app but sitemap now uses graspful.com as the default base URL. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
next/headers imported at top level in resolve.ts was crashing the Edge Runtime middleware on Vercel (MIDDLEWARE_INVOCATION_FAILED). Moved to dynamic import inside resolvePageBrand() which only runs in Server Components, not middleware. Also fix sitemap test to match new base URL. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vercel-domains.service.spec.ts: mock usesgetinstead ofgetOrThrow(matches the service change from PR fix: Vercel build, graceful env degradation, e2e test fixes #32)vercel.jsonscoping Vercel build toapps/webonlyTest plan
cd backend && bun run buildpassescd apps/web && npx next buildpasses🤖 Generated with Claude Code