-
-
Notifications
You must be signed in to change notification settings - Fork 823
fixes #69 #1222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carneeki
wants to merge
3
commits into
winder:master
Choose a base branch
from
carneeki:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fixes #69 #1222
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,6 +47,7 @@ public abstract class BufferedCommunicator extends AbstractCommunicator { | |
| private int sentBufferSize = 0; | ||
|
|
||
| private Boolean singleStepModeEnabled = false; | ||
| private Boolean singleBlockModeEnabled = false; | ||
|
|
||
| abstract public int getBufferSize(); | ||
|
|
||
|
|
@@ -69,6 +70,16 @@ public void setSingleStepMode(boolean enable) { | |
| public boolean getSingleStepMode() { | ||
| return this.singleStepModeEnabled; | ||
| } | ||
|
|
||
| @Override | ||
| public void setSingleBlockMode(boolean enable) { | ||
| this.singleBlockModeEnabled = enable; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean getSingleBlockMode() { | ||
| return this.singleBlockModeEnabled; | ||
| } | ||
|
|
||
| /** | ||
| * Add command to the command queue outside file mode. This is the only way | ||
|
|
@@ -187,6 +198,32 @@ else if (!this.commandBuffer.isEmpty()) { | |
| } | ||
| return null; | ||
| } | ||
|
|
||
| private GcodeCommand peekNextCommand() { | ||
| GcodeCommand nc = null; | ||
|
|
||
| if (nextCommand != null) { | ||
| nc = nextCommand; | ||
| } | ||
| else if (!this.commandBuffer.isEmpty()) { | ||
| nc = new GcodeCommand(commandBuffer.peek()); | ||
| } | ||
| else | ||
| try { | ||
| if (commandStream != null && commandStream.ready()) | ||
| { | ||
| nc = commandStream.peekNextCommand(); | ||
| } | ||
| } catch (IOException ignored) { | ||
| // Fall through to null handling. | ||
| } | ||
|
|
||
| if (nc != null && nc.getCommandString().endsWith("\n")) { | ||
| nc.setCommand(nextCommand.getCommandString().trim()); | ||
| } | ||
|
|
||
| return nc; | ||
| } | ||
|
|
||
| /** | ||
| * Streams anything in the command buffer to the comm port. | ||
|
|
@@ -235,6 +272,18 @@ && allowMoreCommands()) { | |
| e.printStackTrace(); | ||
| System.exit(-1); | ||
| } | ||
|
|
||
| // Single block mode: pause after this command is sent | ||
| // iff the next command is from the commandStream | ||
| // (ie do not pause for commandBuffer commands) | ||
| if( this.getSingleBlockMode() && | ||
| commandBuffer.isEmpty() && | ||
| peekNextCommand() != null && | ||
| !peekNextCommand().getCommandString().isEmpty() ) { | ||
|
|
||
| logger.log(Level.INFO, "singleBlockMode: pausing"); | ||
| pauseSend(); | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think |
||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.