Add draggable reader translation popup - #1459
Open
stephenchiao wants to merge 1 commit into
Open
Conversation
stephenchiao
marked this pull request as ready for review
August 18, 2026 07:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
translateproperty so Zotero's native positioning transform remains intactMotivation
Zotero's selection popup is anchored above or below the selected text. When a translation grows, the popup can cover figures or other content that the user is reading. The existing textarea can be resized, but the popup cannot be moved.
This change lets users drag the complete popup from a small, dedicated handle without interfering with text selection, textarea resizing, color controls, or note actions.
Implementation notes
The drag interaction uses Pointer Events and pointer capture within the reader document. The plugin updates the individual CSS
translateproperty rather than replacingstyle.transform, which is controlled by Zotero's reader popup positioning. Movement is clamped to the reader viewport, including after translated content changes the popup size.Validation
npx prettier --check src/modules/popup.tsnpx eslint src/modules/popup.tsnpm run buildThe production XPI builds successfully.