Skip to content

Commit 0179176

Browse files
committed
perf: optimize N+1 user role save operations
Moved $editedUser->save() outside of the loops in attachRolesToUser to reduce database operations from O(N) to O(1). Also removed a redundant intermediate save() call to ensure all role changes (removals and additions) are persisted in a single operation.
1 parent 1b28339 commit 0179176

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

‎src/Helpers/PwUserTools.php‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,6 @@ public function attachRolesToUser($user, $roles, $output, $reset = false) {
9494
$editedUser->removeRole($role->name);
9595
}
9696
}
97-
$editedUser->save();
98-
9997
// remove existing roles
10098
if ($reset === true) {
10199
foreach ($editedUser->roles as $role) {
@@ -109,9 +107,10 @@ public function attachRolesToUser($user, $roles, $output, $reset = false) {
109107
$this->checkIfRoleExists($role, $output);
110108

111109
$editedUser->addRole($role);
112-
$editedUser->save();
113110
}
114111

112+
$editedUser->save();
113+
115114
return $editedUser;
116115
}
117116

0 commit comments

Comments
 (0)