Repository navigation
Fix SDHCI to clear BWR before refilling the PIO write buffer - #939
Merged
Merged
Conversation
dgarske
force-pushed
the
sdhci_pio_write
branch
from
October 15, 2026 04:16
15631d2 to
7a92f2b
Compare
danielinux
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BWR is W1C and the PIO write loop never acked it, so it refilled on a stale flag and hung above 4 KB.
The sdhci-disk mock latched BWR for the whole transfer; it now raises it per block and rejects an unacked refill, so the hang is caught hosted.
Tested on VMK180: 512 B to 1 MB write/read-back verified, then a signed 16 MB FIT booted from SD.