Repository navigation
Bound READDIR and fix SFTP server status codes - #1332
Open
ejohnstown wants to merge 4 commits into
Open
ejohnstown wants to merge 4 commits into
ejohnstown wants to merge 4 commits into
Conversation
wolfSSH_SFTP_read() answers a request type it has no handler for, SSH_FXP_EXTENDED among them, with SSH_FX_OP_UNSUPPORTED rather than the generic SSH_FX_FAILURE (draft-ietf-secsh-filexfer-02 Section 7). Issue: F-8840
RecvReadDir() puts at most WOLFSSH_MAX_SFTP_READDIR entries (default 100) in one NAME reply and keeps the handle's place, so a large directory takes several requests. The readdir helpers return WS_EOF at the end of the directory; any other failure, an allocation included, answers SSH_FX_FAILURE instead of EOF or a short listing. - free the entry list on every path - the POSIX helper tells a readdir() error from the end by errno - an entry whose full path does not fit is listed without attributes - a SFTP_Name_readdir hook failure other than WS_MEMORY_E ends the listing; WS_NEXT_ERROR still marks the last entry - WOLFSSH_MAX_SFTP_READDIR below 1 is a build error Issue: F-10552, F-13429
RecvOpenDir() allocates the directory node, its name and the HANDLE reply before linking the node into dirList, so an allocation failure leaves no handle the peer was never told about. Both the POSIX and the Windows branch. Issue: F-10551
STAT, LSTAT, OPEN, REMOVE, RENAME and OPENDIR take the status for a failed call from errno, as OpenSSH's sftp-server does: ENOENT and ENOTDIR answer SSH_FX_NO_SUCH_FILE, EACCES and EPERM SSH_FX_PERMISSION_DENIED, anything else SSH_FX_FAILURE. Only the default POSIX file system sets errno; other ports keep their old status. - OPENDIR on POSIX no longer reports every failure as NO_SUCH_FILE Issue: F-16081
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1332
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 2 of 5 in-scope changed file(s) opened by the reviewer; not opened: tests/unit.c, wolfssh/port.h, wolfssh/wolfsftp.h
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SFTP server fixes for directory listing and status codes. READDIR replies
are bounded and resumable, errors no longer look like EOF, and failed calls
report why on POSIX.
reply; a real error answers SSH_FX_FAILURE, and an entry whose full path
is too long is listed without attributes.
branch is compile-checked by CI only.
NO_SUCH_FILE and EACCES/EPERM to PERMISSION_DENIED; other ports keep
their old status.
Behavior to note: a
SFTP_Name_readdirhook failure other thanWS_MEMORY_Eends the listing, and OPENDIR on a regular file answersNO_SUCH_FILE, as in OpenSSH.
Fenrir: F-8840, F-10551, F-10552, F-13429, F-16081