Fix extension handling for quic_transport_parameters and trusted_ca_keys - #11304
Open
gasbytes wants to merge 1 commit into
Open
Fix extension handling for quic_transport_parameters and trusted_ca_keys#11304gasbytes wants to merge 1 commit into
gasbytes wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates TLSX_Parse() in the TLS stack to enforce RFC-required handling for two specific extensions, aligning fatal alerts and message-type validity checks with current specifications.
Changes:
- Rejects
trusted_ca_keysin TLS 1.3 when received in any handshake message other thanClientHello(previously silently ignored). - For
quic_transport_parametersreceived on a non-QUIC connection, sends a fatalunsupported_extensionalert and returnsUNSUPPORTED_EXTENSION(instead of mapping toillegal_parameter).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Can one of the admins verify this patch? |
…non-quic connections rfc 9001 section 8.2 - tls: reject trusted_ca_keys outside ClientHello in TLS 1.3 RFC 9846 Sec 4.3.4
gasbytes
force-pushed
the
tls-alert-fixes
branch
from
August 28, 2026 11:53
50159bf to
62843dd
Compare
gasbytes
marked this pull request as ready for review
August 28, 2026 11:55
|
retest this please |
|
Contributor
Author
|
Jenkins retest this please |
philljj
self-requested a review
August 30, 2026 00:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two RFC-conformance fixes in TLSX_Parse: quic_transport_parameters on a non-QUIC connection now aborts with a fatal unsupported_extension alert instead of illegal_parameter (RFC 9001 Sec. 8.2), and trusted_ca_keys received in any TLS 1.3 message other than ClientHello is now rejected instead of silently ignored (RFC 9846 Sec. 4.3.4).
Testing
Added associated regression tests (
test_TLSX_TCA_tls13_msg_type_validationandtest_TLSX_QUIC_TP_non_quic).Checklist