Rust wrapper: ecdsa: allow module usage for verify-only ECC builds - #11321
Open
holtrop-wolfssl wants to merge 1 commit into
Open
Rust wrapper: ecdsa: allow module usage for verify-only ECC builds#11321holtrop-wolfssl wants to merge 1 commit into
holtrop-wolfssl wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Rust wolfssl-wolfcrypt ECDSA signature-trait wrapper so the ecdsa module can be used in ECC verify-only wolfCrypt builds (i.e., without requiring signing/export/RNG support for the entire module).
Changes:
- Relaxed
ecdsamodule-levelcfggating to only require ECC import + verify capabilities, while gating signing-key pieces more narrowly. - Switched curve identifiers to
ECC::SECP*constants (removing the direct dependency onecc_curve_idsenums). - Updated the ECDSA trait test module gating to match the APIs it actually uses (import/export/sign/verify + RNG).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wrapper/rust/wolfssl-wolfcrypt/tests/test_ecdsa.rs | Tightens/aligns test cfg gating with the ECC import/export/sign/verify + RNG APIs used by the tests. |
| wrapper/rust/wolfssl-wolfcrypt/src/ecdsa.rs | Refactors ECDSA wrapper gating for verify-only builds; adds conditional imports/signing helpers; uses ECC::SECP* curve IDs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Can one of the admins verify this patch? |
holtrop-wolfssl
force-pushed
the
f-10091
branch
from
August 31, 2026 14:43
b8dd136 to
f31e461
Compare
Contributor
Author
|
retest this please (Cloning the remote Git repository |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rust wrapper: ecdsa: allow module usage for verify-only ECC builds
Fixes F-10091
Testing
How did you test?
Checklist