Repository navigation
Conversation
The Common.List (Common.Basic ...) branch in paramToString was ignoring the format field, so UUID arrays used plain string identity instead of Uuid.toString. Now uses CliMonad.withFormat like the non-list Basic case. Add test, example spec, and TestGenScript entry for uuid-array-param.
wolfadex
approved these changes
Mar 6, 2026
Contributor
Author
|
Don't merge yet, I just found it's failing on a complex spec, I'm bisecting to get to the bottom of it. |
Contributor
Author
|
False alarm. The generator crashed due to a combination of elm-pages update and using |
Merge path item parameters with operation parameters per the OpenAPI
spec. Previously, parameters defined at the path level (shared across
all operations) were silently ignored, causing path params like {orgId}
to appear as literal strings in generated URLs.
miniBill
reviewed
Mar 6, 2026
miniBill
reviewed
Mar 6, 2026
Comment on lines
+847
to
+860
| let | ||
| trimTrailingWhitespace : String -> String | ||
| trimTrailingWhitespace = | ||
| String.lines >> List.map String.trimRight >> String.join "\n" | ||
|
|
||
| normalizedExp : String | ||
| normalizedExp = | ||
| trimTrailingWhitespace exp | ||
|
|
||
| normalizedActual : String | ||
| normalizedActual = | ||
| trimTrailingWhitespace actual | ||
| in | ||
| if normalizedExp == normalizedActual then |
Collaborator
There was a problem hiding this comment.
I don't love this? I think I'd prefer to keep the trailing whitespace in the actual tbh?
Contributor
Author
|
I need to move this fix to a dedicated branch instead of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Common.List (Common.Basic ...) branch in paramToString was ignoring the format field, so UUID arrays used plain string identity instead of Uuid.toString. Now uses CliMonad.withFormat like the non-list Basic case.
Add test, example spec, and TestGenScript entry for uuid-array-param.