Skip to content

Commit 5f1d3c9

Browse files
rafmacalabaavsolatorio
authored andcommitted
fix(resources): resolve server_base with fallback and window.location.origin
1 parent 2bec965 commit 5f1d3c9

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

src/data360/mcp_server/resources.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ async def vega_lite_renderer(spec: str | None = None) -> str:
368368

369369
settings = get_mcp_server_settings()
370370
port = settings.port or 8021
371-
server_base = f"http://localhost:{port}"
371+
server_base = getattr(settings, "server_base_url", None) or f"http://localhost:{port}"
372372
return render_template("vega_lite_renderer.jinja2", server_base=server_base, pre_loaded_spec=spec)
373373

374374

src/data360/templates/vega_lite_renderer.jinja2

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
<pre id="error-stack"></pre>
5757
</div>
5858
<script type="module">
59-
const serverBaseUrl = "{{ server_base }}";
59+
const serverBaseUrl = "{{ server_base }}" || window.location.origin;
6060
6161
function showError(message, stack) {
6262
document.getElementById('vis').style.display = 'none';
@@ -92,7 +92,8 @@
9292
logToServer("Unhandled promise rejection", { message: msg, stack: stack });
9393
});
9494
95-
import { App } from "{{ server_base }}/static/libs/ext-apps.js";
95+
const extAppsUrl = serverBaseUrl + "/static/libs/ext-apps.js";
96+
const { App } = await import(extAppsUrl);
9697
9798
if (window.PRE_LOADED_SPEC) {
9899
vegaEmbed("#vis", window.PRE_LOADED_SPEC, {

0 commit comments

Comments
 (0)