Add cancellable GIF size estimates - #1283
Open
landeqiming666 wants to merge 1 commit into
Open
landeqiming666 wants to merge 1 commit into
landeqiming666 wants to merge 1 commit into
Conversation
Author
|
CircleCI did not reach checkout or run this change. The job was rejected because the repository macOS executor combines Local validation completed: full AVA suite, both TypeScript projects, focused lint, production renderer build/export, and |
Collaborator
|
7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an approximate GIF size next to the editor export controls. The estimate converts a short sample with the same dimensions, frame rate, and selected range, then scales it to the full duration.
The estimate is canceled when export options change, the format changes, or the editor component is unmounted, so an obsolete background conversion does not continue after the result can no longer be shown. The probe deliberately does not invoke edit services because those can be interactive or have side effects.
Validation
TS_NODE_TRANSPILE_ONLY=1 node ./node_modules/ava/cli.jsnode ./node_modules/typescript/bin/tsc --noEmit -p tsconfig.jsonnode ./node_modules/typescript/bin/tsc --noEmit -p renderer/tsconfig.jsonnode ./node_modules/next/dist/bin/next build renderernode ./node_modules/next/dist/bin/next export renderergit diff --checkCloses #172