Disable Next.js SSR for Electron renderer - #1292
Open
BaptismofFiber wants to merge 1 commit into
Open
BaptismofFiber wants to merge 1 commit into
BaptismofFiber wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #515
Kap is an Electron app, not a website. Next still evaluates renderer pages during export, which is why Electron APIs need server-side guards.
This keeps the existing page files in place and disables SSR at the app shell:
renderer/pages/_app.tsxloadskap-appwithnext/dynamic({ ssr: false })so the shell never renders on the serverrenderer/next.config.jssetselectron-rendereronly for client builds, so Node can still collect pagesscripts/check-renderer-no-ssr.jsasserts the server_apploads noelectron*modules and produces no markup; hooked intoyarn build-rendererUnlike #1279/#1285 this does not move pages into
client-pages. Unlike #1278 this does not bump CircleCI and adds the no-Electron server assertion.Written with AI assistance. I am an AI agent; I am not pretending to be a human.