Exercise strict signal handling and additional archive/release refusal cases

Author: xPROMSx

tests/acme.sh

@@ -54,7 +54,7 @@ for scenario in free webroot foreign conflict invalid-nginx failed-certbot inter
             "$ACME_ROOT" "$DOMAIN" "$ACME_ROOT" >"$CERT_ROOT/renewal/$DOMAIN.conf"
     }
     set +e
-    (ensure_certificate) >"$case_dir/manager.log" 2>&1
+    (set -Eeuo pipefail; ensure_certificate) >"$case_dir/manager.log" 2>&1
     result=$?
     set -e
     if [[ ( $scenario == free || $scenario == webroot ) && $result != 0 ]]; then

tests/download.sh

@@ -24,6 +24,14 @@ result=$?
 set -e
 [[ $result != 0 && ! -e $SANDBOX/executed ]]
 metadata "$(sha256sum "$SANDBOX/source.tar.gz" | cut -d' ' -f1)"
+jq '.assets += .assets' "$TMP/release.json" >"$TMP/duplicate.json"
+mv "$TMP/duplicate.json" "$TMP/release.json"
+set +e
+(download_candidate) >"$SANDBOX/duplicate.log" 2>&1
+result=$?
+set -e
+[[ $result != 0 && ! -e $SANDBOX/executed ]]
+metadata "$(sha256sum "$SANDBOX/source.tar.gz" | cut -d' ' -f1)"
 download_candidate
 [[ -e $SANDBOX/executed ]]
 rm "$SANDBOX/executed" "$SANDBOX/archive/telemt"
@@ -35,7 +43,7 @@ set +e
 result=$?
 set -e
 [[ $result != 0 && ! -e $SANDBOX/executed ]]
-printf 'ok - digest mismatch and symlink archive never execute; valid digest passes\n'
+printf 'ok - digest mismatch, ambiguous asset and symlink archive never execute; valid digest passes\n'
 
 # SC2016: preserve positional arguments for the generated candidate stub.
 # shellcheck disable=SC2016

tests/test_safety.py

@@ -1,6 +1,7 @@
 import contextlib
 import importlib.util
 import io
+import gzip
 import json
 import os
 import tarfile
@@ -276,6 +277,30 @@ def test_unsafe_archive_variants_never_create_binary(self):
                 with self.assertRaises(ValueError):
                     s.extract_binary(archive, output)
                 self.assertFalse(output.exists())
+            member = tarfile.TarInfo('telemt')
+            member.size = 128 * 1024 * 1024 + 1
+            with gzip.open(archive, 'wb') as compressed:
+                compressed.write(member.tobuf() + b'\0' * 1024)
+            with self.assertRaises(ValueError):
+                s.extract_binary(archive, output)
+            self.assertFalse(output.exists())
+
+    @unittest.skipUnless(os.name == 'posix', 'Unix flags checked on Linux CI')
+    def test_archive_output_symlink_does_not_overwrite_target(self):
+        with tempfile.TemporaryDirectory() as tmp:
+            root = Path(tmp)
+            target = root/'target'
+            target.write_bytes(b'unchanged')
+            output = root/'binary'
+            output.symlink_to(target)
+            archive = root/'asset.tar.gz'
+            with tarfile.open(archive, 'w:gz') as tar:
+                member = tarfile.TarInfo('telemt')
+                member.size = 7
+                tar.addfile(member, io.BytesIO(b'fixture'))
+            with self.assertRaises(OSError):
+                s.extract_binary(archive, output)
+            self.assertEqual(target.read_bytes(), b'unchanged')
 
     @unittest.skipUnless(os.name == 'posix', 'Unix permissions checked on Linux CI')
     def test_symlink_and_writable_ancestor_refused(self):